View Issue Details

IDProjectCategoryView StatusLast Update
0006049DarkRadiantGUIpublic06.08.2022 04:27
ReporterDragofer Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.0.0 
Target Version3.1.0Fixed in Version3.1.0 
Summary0006049: Material Editor: using Escape to close ignores unsaved changes
DescriptionIt's possible to close the material editor by pressing the Escape key instead of "Close". The editor closes instantly without asking whether one wants to save or discard unsaved changes.

When pressing Escape, it appears that:
1) unsaved copied materials are discarded (but still seem to exist, since further copies won't have the same name as the discarded copy)
2) changes to image paths are temporarily saved until DR is closed
Steps To Reproduce[Unsaved copied materials are discarded]
1) Search for "cubedome" >> select "textures/skies/cubeDome"
2) Click on "Unlock Editing" to create a copy called cubeDome_copy, then press Escape. The Material Editor closes without asking whether one wants to save the new material.
3) Open the Material Editor again and select the material from step 1 again. The copy made in step 2 is gone from the Material Definitions list.
4) Click on "Unlock Editing" again to create another copy. This one is called cubeDome_copy01, so it appears the first copy from step 2 still exists somewhere. But the search function can't find it.

[Changes to image paths are temporarily saved until DR is restarted]
5) This time save the copy made in step 4.
6) Make any change to the editor image path, i.e. insert a 1 at the beginning to break it, then press Escape. The Material Editor closes without asking to save the change.
7) Open the Material Editor again and find the modified material from step 5-6 again. The changed image path seems to have been saved.
8) Restart DR, open the Material Editor again and find the modified material from step 5-6 again. The change to the image path has been reverted.
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

DarkRadiant: master 86887433

2022-08-06 04:27:25

greebo

Details Diff
0006049: Prompt the user whether to save unsaved modifications to materials when hitting ESC. Affected Issues
0006049
mod - radiant/ui/materials/editor/MaterialEditor.cpp Diff File
mod - radiant/ui/materials/editor/MaterialEditor.h Diff File

Issue History

Date Modified Username Field Change
31.07.2022 11:44 Dragofer New Issue
31.07.2022 11:50 Dragofer Description Updated
31.07.2022 11:50 Dragofer Steps to Reproduce Updated
31.07.2022 11:51 Dragofer Description Updated
31.07.2022 11:51 Dragofer Steps to Reproduce Updated
31.07.2022 11:51 Dragofer Steps to Reproduce Updated
31.07.2022 15:05 greebo Status new => acknowledged
06.08.2022 04:25 greebo Status acknowledged => confirmed
06.08.2022 04:25 greebo Assigned To => greebo
06.08.2022 04:25 greebo Status confirmed => assigned
06.08.2022 04:25 greebo Target Version => 3.1.0
06.08.2022 04:27 greebo Changeset attached => DarkRadiant master 86887433
06.08.2022 04:27 greebo Status assigned => resolved
06.08.2022 04:27 greebo Resolution open => fixed
06.08.2022 04:27 greebo Fixed in Version => 3.1.0