View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0006054||DarkRadiant||GUI||public||01.08.2022 12:05||21.08.2022 20:14|
|Target Version||3.1.0||Fixed in Version||3.1.0|
|Summary||0006054: Material Editor: image browser's "cancel" button rewrites the material source text|
|Description||Clicking "cancel" in the material editor's image browser restores the original entry in the image path field (unless 0006032), but still seems to put the material source text through the parser and flags the material as having an unsaved change. This is problematic because this can lead to the loss of comments or alter keywords, as pointed out in earlier tickets.|
|Steps To Reproduce||1) Search for "rough_dirty" > select textures/darkmod/metal/flat/tiling_1d/rough_dirty01.|
2) Click on "Unlock Editing" and then "Save Material" to save the copy.
3) Expand the material source text.
4) Click on one of the "..." buttons next to the map fields in the Basic tab to open the image browser.
5) While looking at the material source text, click on "Cancel". The source text is rewritten and the material is flagged as having an unsaved change.
|Tags||No tags attached.|
Same problem as in 0006038.
|The problem here is that clicking "Cancel" while selecting an image still counts as a change that causes a rewrite.|
|It's not even clicking cancel, it's opening the browser itself is causing a new definition generation. Opening the Image browser will select the current item in the list, which is an "item selected" event which in turn causes a change signal to be fired to the Material Editor's map entry box => material gets a new map expression assigned and the text is re-generated.|
|In 3.1, opening the image browser doesn't regenerate the text, but clicking 'Cancel' still does.|
DarkRadiant: master 8799d29f
|0006054: Update the target text entry control only if the value actually changed. This prevents materials from being flagged as modified even though the user was just looking around.||
|mod - radiant/ui/common/ImageFileSelector.cpp||Diff File|
|01.08.2022 12:05||Dragofer||New Issue|
|01.08.2022 12:05||Dragofer||Issue generated from: 0006032|
|01.08.2022 12:05||Dragofer||Relationship added||related to 0006032|
|01.08.2022 12:31||Dragofer||Summary||Material Editor: image browser's "cancel" button counts as a saveable change => Material Editor: image browser's "cancel" button rewrites the material source text|
|05.08.2022 06:26||greebo||Relationship added||related to 0006052|
|05.08.2022 06:26||greebo||Status||new => acknowledged|
|05.08.2022 06:26||greebo||Note Added: 0015120|
|05.08.2022 06:27||greebo||Relationship deleted||related to 0006052|
|05.08.2022 06:27||greebo||Relationship added||related to 0006038|
|05.08.2022 06:27||greebo||Note Edited: 0015120|
|05.08.2022 08:52||Dragofer||Note Added: 0015121|
|05.08.2022 17:18||greebo||Note Added: 0015125|
|15.08.2022 13:14||greebo||Status||acknowledged => confirmed|
|15.08.2022 13:14||greebo||Assigned To||=> greebo|
|15.08.2022 13:14||greebo||Status||confirmed => assigned|
|15.08.2022 13:14||greebo||Target Version||=> 3.1.0|
|15.08.2022 13:16||greebo||Changeset attached||=> DarkRadiant master 8799d29f|
|15.08.2022 13:16||greebo||Status||assigned => resolved|
|15.08.2022 13:16||greebo||Resolution||open => fixed|
|15.08.2022 13:16||greebo||Fixed in Version||=> 3.1.0|
|21.08.2022 20:14||Dragofer||Note Added: 0015200|