View Issue Details

IDProjectCategoryView StatusLast Update
0006073DarkRadiantGeneralpublic14.08.2022 16:48
Reportergreebo Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version3.1.0 
Target Version3.1.0Fixed in Version3.1.0 
Summary0006073: Renaming Declarations causes problems when saving it later
DescriptionThe DeclarationManager has troubles locating the original location in the file when trying to save or delete a material that has been renamed after parsing.
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

DarkRadiant: master bf551004

14.08.2022 14:04

greebo


Details Diff
0006073: Introduce IDeclaration::setDeclName() method, though it's for internal use only. Affected Issues
0006073
mod - include/ideclmanager.h Diff File
mod - libs/decl/DeclarationBase.h Diff File
mod - test/DeclManager.cpp Diff File

DarkRadiant: master 457419bb

14.08.2022 14:12

greebo


Details Diff
0006073: IDeclarationManager::renameDeclaration is now changing the name in the decl too. Affected Issues
0006073
mod - radiantcore/decl/DeclarationManager.cpp Diff File
mod - test/DeclManager.cpp Diff File

DarkRadiant: master deda404e

14.08.2022 14:50

greebo


Details Diff
0006073: Add unit test checking the behaviour when saving a renamed decl Affected Issues
0006073
mod - include/ideclmanager.h Diff File
mod - libs/decl/DeclarationBase.h Diff File
mod - radiantcore/decl/DeclarationManager.cpp Diff File
mod - test/DeclManager.cpp Diff File

DarkRadiant: master 070de47a

14.08.2022 14:55

greebo


Details Diff
0006073: Another unit test checking removal of a renamed decl Affected Issues
0006073
mod - test/DeclManager.cpp Diff File

DarkRadiant: master bad51a89

14.08.2022 15:05

greebo


Details Diff
0006073: Extend the save and delete unit tests checking a second rename operation after save/delete Affected Issues
0006073
mod - test/DeclManager.cpp Diff File

DarkRadiant: master c11ec668

14.08.2022 15:30

greebo


Details Diff
0006073: Adjust saveDeclaration and removeDeclaration implementations to handle renamed decls. Affected Issues
0006073
mod - include/ideclmanager.h Diff File
mod - libs/decl/DeclarationBase.h Diff File
mod - libs/parser/DefBlockSyntaxParser.h Diff File
mod - radiantcore/decl/DeclarationManager.cpp Diff File

DarkRadiant: master 0a0b8c0e

14.08.2022 15:37

greebo


Details Diff
0006073: Renaming an unchanged material will mark the instance as modified Affected Issues
0006073
mod - radiantcore/shaders/MaterialManager.cpp Diff File
mod - test/Materials.cpp Diff File

DarkRadiant: master 20f8656e

14.08.2022 16:47

greebo


Details Diff
0006073: Keep the renamed material selected in the tree view Affected Issues
0006073
mod - radiant/ui/materials/editor/MaterialEditor.cpp Diff File

Issue History

Date Modified Username Field Change
14.08.2022 14:18 greebo New Issue
14.08.2022 14:18 greebo Assigned To => greebo
14.08.2022 14:18 greebo Status new => assigned
14.08.2022 15:37 greebo Changeset attached => DarkRadiant master bf551004
14.08.2022 15:37 greebo Changeset attached => DarkRadiant master 457419bb
14.08.2022 15:37 greebo Changeset attached => DarkRadiant master deda404e
14.08.2022 15:37 greebo Changeset attached => DarkRadiant master 070de47a
14.08.2022 15:37 greebo Changeset attached => DarkRadiant master bad51a89
14.08.2022 15:37 greebo Changeset attached => DarkRadiant master c11ec668
14.08.2022 15:37 greebo Changeset attached => DarkRadiant master 0a0b8c0e
14.08.2022 16:47 greebo Changeset attached => DarkRadiant master 20f8656e
14.08.2022 16:48 greebo Status assigned => resolved
14.08.2022 16:48 greebo Resolution open => fixed
14.08.2022 16:48 greebo Fixed in Version => 3.1.0