View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006073 | DarkRadiant | General | public | 14.08.2022 14:18 | 13.01.2024 05:31 |
| Reporter | greebo | Assigned To | greebo | ||
| Priority | normal | Severity | normal | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.1.0 | ||||
| Target Version | 3.1.0 | Fixed in Version | 3.1.0 | ||
| Summary | 0006073: Renaming Declarations causes problems when saving it later | ||||
| Description | The DeclarationManager has troubles locating the original location in the file when trying to save or delete a material that has been renamed after parsing. | ||||
| Tags | No tags attached. | ||||
|
DarkRadiant: master bf551004 14.08.2022 14:04 Details Diff |
0006073: Introduce IDeclaration::setDeclName() method, though it's for internal use only. |
Affected Issues 0006073 |
|
| mod - include/ideclmanager.h | Diff File | ||
| mod - libs/decl/DeclarationBase.h | Diff File | ||
| mod - test/DeclManager.cpp | Diff File | ||
|
DarkRadiant: master 457419bb 14.08.2022 14:12 Details Diff |
0006073: IDeclarationManager::renameDeclaration is now changing the name in the decl too. |
Affected Issues 0006073 |
|
| mod - radiantcore/decl/DeclarationManager.cpp | Diff File | ||
| mod - test/DeclManager.cpp | Diff File | ||
|
DarkRadiant: master deda404e 14.08.2022 14:50 Details Diff |
0006073: Add unit test checking the behaviour when saving a renamed decl |
Affected Issues 0006073 |
|
| mod - include/ideclmanager.h | Diff File | ||
| mod - libs/decl/DeclarationBase.h | Diff File | ||
| mod - radiantcore/decl/DeclarationManager.cpp | Diff File | ||
| mod - test/DeclManager.cpp | Diff File | ||
|
DarkRadiant: master 070de47a 14.08.2022 14:55 Details Diff |
0006073: Another unit test checking removal of a renamed decl |
Affected Issues 0006073 |
|
| mod - test/DeclManager.cpp | Diff File | ||
|
DarkRadiant: master bad51a89 14.08.2022 15:05 Details Diff |
0006073: Extend the save and delete unit tests checking a second rename operation after save/delete |
Affected Issues 0006073 |
|
| mod - test/DeclManager.cpp | Diff File | ||
|
DarkRadiant: master c11ec668 14.08.2022 15:30 Details Diff |
0006073: Adjust saveDeclaration and removeDeclaration implementations to handle renamed decls. |
Affected Issues 0006073 |
|
| mod - include/ideclmanager.h | Diff File | ||
| mod - libs/decl/DeclarationBase.h | Diff File | ||
| mod - libs/parser/DefBlockSyntaxParser.h | Diff File | ||
| mod - radiantcore/decl/DeclarationManager.cpp | Diff File | ||
|
DarkRadiant: master 0a0b8c0e 14.08.2022 15:37 Details Diff |
0006073: Renaming an unchanged material will mark the instance as modified |
Affected Issues 0006073 |
|
| mod - radiantcore/shaders/MaterialManager.cpp | Diff File | ||
| mod - test/Materials.cpp | Diff File | ||
|
DarkRadiant: master 20f8656e 14.08.2022 16:47 Details Diff |
0006073: Keep the renamed material selected in the tree view |
Affected Issues 0006073 |
|
| mod - radiant/ui/materials/editor/MaterialEditor.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 14.08.2022 14:18 | greebo | New Issue | |
| 14.08.2022 14:18 | greebo | Assigned To | => greebo |
| 14.08.2022 14:18 | greebo | Status | new => assigned |
| 14.08.2022 15:37 | greebo | Changeset attached | => DarkRadiant master bf551004 |
| 14.08.2022 15:37 | greebo | Changeset attached | => DarkRadiant master 457419bb |
| 14.08.2022 15:37 | greebo | Changeset attached | => DarkRadiant master deda404e |
| 14.08.2022 15:37 | greebo | Changeset attached | => DarkRadiant master 070de47a |
| 14.08.2022 15:37 | greebo | Changeset attached | => DarkRadiant master bad51a89 |
| 14.08.2022 15:37 | greebo | Changeset attached | => DarkRadiant master c11ec668 |
| 14.08.2022 15:37 | greebo | Changeset attached | => DarkRadiant master 0a0b8c0e |
| 14.08.2022 16:47 | greebo | Changeset attached | => DarkRadiant master 20f8656e |
| 14.08.2022 16:48 | greebo | Status | assigned => resolved |
| 14.08.2022 16:48 | greebo | Resolution | open => fixed |
| 14.08.2022 16:48 | greebo | Fixed in Version | => 3.1.0 |
| 13.01.2024 05:31 | greebo | Status | resolved => closed |
