View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0006241 | The Dark Mod | GUI | public | 23.01.2023 01:52 | 26.01.2023 21:29 |
Reporter | Daft Mugi | Assigned To | stgatilov | ||
Priority | normal | Severity | normal | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | SVN | ||||
Target Version | TDM 2.11 | Fixed in Version | TDM 2.11 | ||
Summary | 0006241: invgrid backdrop conflicts with 'missions list' backdrop | ||||
Description | Both 'guis/tdm_invgrid_parchment.gui' and 'guis/mainmenu_newgame.gui' use 'dds/guis/assets/mainmenu/oldparchment_backdrop5.dds'. This creates a problem when the player overrides 'oldparchment_backdrop5.dds' to mod the inventory, because it also overrides the 'missions list' backdrop. One reason to override 'oldparchment_backdrop5.dds' is to reduce the brightness of the inventory. Proposal: Use a dedicated backdrop for the inventory. Change 'guis/tdm_invgrid_parchment.gui' to instead use a new DDS file called 'dds/guis/assets/mainmenu/invgrid_parchment_backdrop.dds'. To start, 'invgrid_parchment_backdrop.dds' would be an identical copy of 'oldparchment_backdrop5.dds'. | ||||
Steps To Reproduce | 1. Edit 'dds/guis/assets/mainmenu/oldparchment_backdrop5.dds' 2. Go to 'Missions List' and click on a mission. 3. Look at parchment backdrop on the left. 4. In-game, open the inventory. 5. Look at the inventory backdrop. | ||||
Tags | No tags attached. | ||||
Attached patch. Also, attached identical copy of 'oldparchment_backdrop5.dds' as 'invgrid_parchment_backdrop.dds'. r16758-change-invgrid-parchment.diff (437 bytes)
diff --git guis/tdm_invgrid_parchment.gui guis/tdm_invgrid_parchment.gui index 4d75984..ceb1d50 100644 --- guis/tdm_invgrid_parchment.gui +++ guis/tdm_invgrid_parchment.gui @@ -355,7 +355,7 @@ windowDef Desktop { rect PARCH_X, PARCH_Y, PARCH_W, PARCH_H matcolor 1, 1, 1, 1 - background "guis/assets/mainmenu/oldparchment_backdrop5" + background "guis/assets/mainmenu/invgrid_parchment_backdrop" noclip 1 visible 1 } |
|
I sorta agree with this. The design was probably done this way to enforce consistency in the GUI interfaces. |
|
@nbohr1more What's the next step for this? That DDS file changing both the in-game GUI and main menu GUI is unexpected. I was surprised, anyway. "Reduced brightness of inventory. Yay! Missions List screen looks weird? Huh, why? =(" |
|
I'm not confident mappers should try to override this texture. And modders can just change the cvar "tdm_invgrid_hud_file" to their custom file if they want. But yeah, that having separate image for invgrid sounds like a right idea. |
|
On the second throught, I'm not sure this is a good idea as it is. There are several more images taken from main menu. Luckily, engine prints message about them (all of them, I hope): Trying to load image guis/assets/mainmenu/invgrid_parchment_backdrop from frontend, deferring... Trying to load image guis/assets/mainmenu/buttons_start/arrow_up from frontend, deferring... Trying to load image guis/assets/mainmenu/buttons_start/arrow_down from frontend, deferring... Trying to load image guis/assets/mainmenu/black_swirl from frontend, deferring... Trying to load image guis/assets/hud/inventory_icons/loot_icon_ruby from frontend, deferring... Trying to load image guis/assets/mainmenu/buttons_start/arrow_up_hover from frontend, deferring... Trying to load image guis/assets/mainmenu/buttons_start/arrow_down_hover from frontend, deferring... And that's with the background already replaced. Obviously, it is not just the background that is shared, there are all images taken from main menu. That's the most natural thing to do to get consistent style. I don't like the idea of copying all the images in order to support image-only mods. |
|
As a workaround, modders can copy whole tdm_invgrid_parchment, and edit it to their liking. Then use the cvar to switch their local version to it. |
|
How do all of those other assets relate to this bug tracker? This bug tracker is only for allowing the player to edit the parchment background. That's it. It's not for modding the entire inventory screen. I'm not understanding the problem with decoupling the parchment background (dds file) from the main menu. |
|
If someone decides to mod the inventory to change its look, he will most certainly change all images. Maybe arrows are probably ignorable, but what about black_swirl ? Hmm... the swirl seems to be always invisible?... |
|
Committed in svn rev 16763. | |
Date Modified | Username | Field | Change |
---|---|---|---|
23.01.2023 01:52 | Daft Mugi | New Issue | |
23.01.2023 01:54 | Daft Mugi | Note Added: 0015851 | |
23.01.2023 01:54 | Daft Mugi | File Added: r16758-change-invgrid-parchment.diff | |
23.01.2023 01:54 | Daft Mugi | File Added: invgrid_parchment_backdrop.dds | |
23.01.2023 13:10 | nbohr1more | Note Added: 0015852 | |
23.01.2023 16:23 | Daft Mugi | Note Added: 0015857 | |
25.01.2023 19:43 | stgatilov | Note Added: 0015886 | |
26.01.2023 20:13 | stgatilov | Note Added: 0015893 | |
26.01.2023 20:14 | stgatilov | Note Added: 0015894 | |
26.01.2023 20:33 | Daft Mugi | Note Added: 0015898 | |
26.01.2023 21:26 | stgatilov | Note Added: 0015905 | |
26.01.2023 21:28 | stgatilov | Note Added: 0015906 | |
26.01.2023 21:29 | stgatilov | Assigned To | => stgatilov |
26.01.2023 21:29 | stgatilov | Status | new => resolved |
26.01.2023 21:29 | stgatilov | Resolution | open => fixed |
26.01.2023 21:29 | stgatilov | Fixed in Version | => TDM 2.11 |
26.01.2023 21:29 | stgatilov | Target Version | => TDM 2.11 |