View Issue Details

IDProjectCategoryView StatusLast Update
0006262The Dark ModSound Systempublic26.02.2023 22:53
Reporterstgatilov Assigned Tostgatilov  
Status feedbackResolutionopen 
Product VersionTDM 2.11 
Target VersionTDM 2.12 
Summary0006262: Allow subtitles to display beyond sound duration
DescriptionSubtitles are implemented in such a way that they are displayed for all the sound samples playing inside the sound system.
As soon as sound ends, it gets deleted form the sound system, and there is no way to display subtitle for it.
Which is quite limiting, especially for very short and quick sounds like "Hey!".

So the idea is to not delete sound from sound system while its subtitles might still be playing.
Additional InformationSee also:
TagsNo tags attached.


related to 0006264 assignedstgatilov Subtitle improvements 




26.02.2023 19:13

administrator   ~0015957

Some preparational commits:
  r10279 Added idSoundSample::DurationIn44kHzSamples in addition to LengthIn44kHzSamples, fixed some usages.
  r10280 Small tweak (use DurationIn44kHzSamples).
  r10281 Some refactoring in idSoundEmitterLocal::CheckForCompletion (avoid copy/paste).
  r10282 Fixed bug that stereo samples take 2x time to "complete" and stop playing.
  r10283 Reworked idSoundChannel::GatherSubtitles to support extension of sound duration for subtitles.


26.02.2023 19:39

administrator   ~0015958

Committed the change in svn rev 10284.
It adds three cvars for now:
  tdm_subtitles_inlineDurationExtension = 0.2 seconds: increase inline subtitles duration
  tdm_subtitles_inlineDurationMinimum = 1 second: inline subtitles duration must be at least this
  tdm_subtitles_durationExtensionLimit = 5 seconds: extension of sound duration due to subtitles is capped by this

The default value of 200 milliseconds is the same as the one hardcoded in conversation system.
So now in a conversation with "wait until finished" talk sounds, subtitles exactly follow each other.

Issue History

Date Modified Username Field Change
26.02.2023 19:11 stgatilov New Issue
26.02.2023 19:11 stgatilov Status new => assigned
26.02.2023 19:11 stgatilov Assigned To => stgatilov
26.02.2023 19:13 stgatilov Note Added: 0015957
26.02.2023 19:39 stgatilov Note Added: 0015958
26.02.2023 22:45 stgatilov Status assigned => feedback
26.02.2023 22:53 stgatilov Relationship added related to 0006264