View Issue Details

IDProjectCategoryView StatusLast Update
0006264The Dark ModSound Systempublic20.02.2024 18:19
Reporterstgatilov Assigned Tostgatilov  
PrioritynormalSeveritynormalReproducibilityhave not tried
Status resolvedResolutionfixed 
Product VersionTDM 2.11 
Target VersionTDM 2.12Fixed in VersionTDM 2.12 
Summary0006264: Subtitle improvements
DescriptionThis would be master-issue for various improvements of subtitles system.
Additional InformationThis is a good thread about the topic:
  https://forums.thedarkmod.com/index.php?/topic/21741-subtitles-possibilities-beyond-211/page/2/
TagsNo tags attached.

Relationships

related to 0006262 resolvedstgatilov Allow subtitles to display beyond sound duration 
related to 0006284 resolvedDragofer Renaming of a few Wench sound files 

Activities

stgatilov

stgatilov

26.02.2023 22:56

administrator   ~0015959

r10285: Improved subtitles system in several ways
  1) Fixed some weird handling of looping sounds in idSoundChannel::GatherSubtitles.
    Verbosity can be different for leadin and loop, also we should fetch subtitles from loop sample when it is playing.
  2) Now more information is returned for subtitle: + sound emitter, sound sample, verbosity,
  3) Better algorithm for assignment of subtitles to slots.
    First of all, high-level subtitles are always displayed in case of overflow, they are never dropped due to many low-level subtitles.
    Second, I fixed the bug that subtitle could be moved (even without overflow) if some new subtitles was added to the list of matches.
    Also, now the algorithm uses the new grouping info (sample and emitter) for better reusage of slots.
 
r10286: Set number of slots to 3 as it is in GUI.
  If we pretend we have more slots that there really are, then slots assignment rules can't do the best assignment in case of overflow.
stgatilov

stgatilov

02.03.2023 20:51

administrator   ~0015960

Two major commits: rev 10288 and rev 16779.

Now there is direction cue and volume cue.
Volume is probably wrong and probably not that important: it is shown by opacity of line cues.
The direction is shown by the line cues: they are arranged in virtual 5.1 speakers setup, and width of a line depends on portion of sound in a speaker.

There is also debug text, show under cvar tdm_subtitles_debug.
stgatilov

stgatilov

01.10.2023 15:16

administrator   ~0016090

Last edited: 01.10.2023 15:44

More changes here:
  r10457. Slightly better volume influence for subtitles.
  r10458. Major rework of subtitles location display.
  r16830. Better font & position for subtitles + major rework of subtitles location display.
  r10459. Expose verbosity of subtitle in GUI.
nbohr1more

nbohr1more

20.02.2024 18:19

developer   ~0016540

Closing as we are in feature freeze. New trackers can be opened for refinements.

Issue History

Date Modified Username Field Change
26.02.2023 22:52 stgatilov New Issue
26.02.2023 22:53 stgatilov Relationship added related to 0006262
26.02.2023 22:53 stgatilov Assigned To => stgatilov
26.02.2023 22:53 stgatilov Status new => assigned
26.02.2023 22:56 stgatilov Note Added: 0015959
02.03.2023 20:51 stgatilov Note Added: 0015960
07.04.2023 15:59 Geep Relationship added related to 0006284
01.10.2023 15:16 stgatilov Note Added: 0016090
01.10.2023 15:44 stgatilov Note Edited: 0016090
05.12.2023 01:19 nbohr1more Status assigned => feedback
20.02.2024 18:19 nbohr1more Note Added: 0016540
20.02.2024 18:19 nbohr1more Status feedback => resolved
20.02.2024 18:19 nbohr1more Resolution open => fixed
20.02.2024 18:19 nbohr1more Fixed in Version => TDM 2.12