View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006332 | DarkRadiant | GUI | public | 01.11.2023 20:10 | 19.01.2024 10:08 |
| Reporter | orbweaver | Assigned To | orbweaver | ||
| Priority | normal | Severity | normal | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux | OS | Ubuntu | OS Version | 22.04 |
| Product Version | 3.8.0 | ||||
| Target Version | 3.9.0 | Fixed in Version | 3.9.0 | ||
| Summary | 0006332: Spinboxes in Background Image panel don't work correctly | ||||
| Description | The spinboxes in Background Image don't work at all: you can enter a number manually, but the +/- buttons do nothing, so they are basically just text boxes. Also they only allow integer values which seem to correspond to very large motion steps, making precise positioning of the background image impossible. | ||||
| Tags | No tags attached. | ||||
|
DarkRadiant: master d98ba072 15.11.2023 20:30 Details Diff |
0006332: OrthoBackgroundPanel stores checkbox pointers as members Store the checkbox pointers as members of a nested struct rather than looking them up from the XML form each time. Also switch to the modern Bind() API for connecting checkbox signals. |
Affected Issues 0006332 |
|
| mod - libs/util/ScopedBoolLock.h | Diff File | ||
| mod - radiant/ui/overlay/OrthoBackgroundPanel.cpp | Diff File | ||
| mod - radiant/ui/overlay/OrthoBackgroundPanel.h | Diff File | ||
|
DarkRadiant: master a0fb69f3 28.11.2023 20:28 Details Diff |
0006332: remove unused argument from OrthoBackgroundPanel::onOptionToggled() |
Affected Issues 0006332 |
|
| mod - radiant/ui/overlay/OrthoBackgroundPanel.cpp | Diff File | ||
| mod - radiant/ui/overlay/OrthoBackgroundPanel.h | Diff File | ||
|
DarkRadiant: master 70c73d85 29.11.2023 20:33 Details Diff |
0006332: OrthoBackgroundPanel stores slider pointers as members As with the checkbox pointers, use a nested member struct to store the slider pointers instead of retrieving them from the XML form each time they are used. Also move common spinner construction code into a separate local function, and create the option checkboxes in code. |
Affected Issues 0006332 |
|
| mod - install/ui/overlaydialog.fbp | Diff File | ||
| mod - install/ui/overlaydialog.xrc | Diff File | ||
| mod - radiant/ui/overlay/OrthoBackgroundPanel.cpp | Diff File | ||
| mod - radiant/ui/overlay/OrthoBackgroundPanel.h | Diff File | ||
|
DarkRadiant: master f2495c1e 21.12.2023 13:22 Details Diff |
0006332: OrthoBackgroundPanel sliders and spinners now added in code Instead of the previous confusing hybrid of XML-based layout and additional widgets inserted via code, all the slider and spinner construction is now done in code. Common code is now refactored into a helper function, and the widget hierarchy is simpler since there is no need for placeholder panels within the XML form to hold the code-constructed spinners. |
Affected Issues 0006332 |
|
| mod - install/ui/overlaydialog.fbp | Diff File | ||
| mod - install/ui/overlaydialog.xrc | Diff File | ||
| mod - radiant/ui/overlay/OrthoBackgroundPanel.cpp | Diff File | ||
|
DarkRadiant: master 254d9c10 21.12.2023 13:41 Details Diff |
0006332: file picker constructed in code |
Affected Issues 0006332 |
|
| mod - install/ui/overlaydialog.fbp | Diff File | ||
| mod - install/ui/overlaydialog.xrc | Diff File | ||
| mod - radiant/ui/overlay/OrthoBackgroundPanel.cpp | Diff File | ||
| mod - radiant/ui/overlay/OrthoBackgroundPanel.h | Diff File | ||
|
DarkRadiant: master c08f33ae 09.01.2024 20:16 Details Diff |
0006332: OrthoBackgroundPanel is entirely constructed in code OrthoBackgroundPanel is no longer an XmlResourceBasedWidget, and the accompanying .xrc/.fbp files are removed. |
Affected Issues 0006332 |
|
| rm - install/ui/overlaydialog.fbp | Diff | ||
| rm - install/ui/overlaydialog.xrc | Diff | ||
| mod - radiant/ui/overlay/OrthoBackgroundPanel.cpp | Diff File | ||
| mod - radiant/ui/overlay/OrthoBackgroundPanel.h | Diff File | ||
|
DarkRadiant: master 3e4c6f5e 10.01.2024 20:03 Details Diff |
0006332: fix broken OrthoBackgroundPanel spinboxes on Linux WxWidgets 3.0.5 on GTK seems to default to 0 decimal places for a wxSpinCtrlDouble, which limits the precision of the sliders (since they are event-linked to the spinboxes) and makes the +/- buttons useless since they attempt to increment the spinbox value by less than the available precision. This appears to be a WxWidgets bug which does not manifest in the latest 3.2 version, but we can work around it in 3.0 by explicitly setting the spin controls to have 2 decimal places. |
Affected Issues 0006332 |
|
| mod - radiant/ui/overlay/OrthoBackgroundPanel.cpp | Diff File | ||
|
DarkRadiant: master 61879986 17.01.2024 20:17 Details Diff |
0006332: document background image functionality |
Affected Issues 0006332 |
|
| mod - doc/manual.adoc | Diff File | ||
|
DarkRadiant: master 530f7b1c 19.01.2024 10:08 Details Diff |
0006332: Fix compiler warnings |
Affected Issues 0006332 |
|
| mod - radiant/ui/overlay/OrthoBackgroundPanel.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 01.11.2023 20:10 | orbweaver | New Issue | |
| 01.11.2023 20:10 | orbweaver | Status | new => assigned |
| 01.11.2023 20:10 | orbweaver | Assigned To | => orbweaver |
| 07.01.2024 06:10 | orbweaver | Changeset attached | => DarkRadiant master d98ba072 |
| 07.01.2024 06:10 | orbweaver | Changeset attached | => DarkRadiant master a0fb69f3 |
| 07.01.2024 06:10 | orbweaver | Changeset attached | => DarkRadiant master 70c73d85 |
| 07.01.2024 06:10 | orbweaver | Changeset attached | => DarkRadiant master f2495c1e |
| 07.01.2024 06:10 | orbweaver | Changeset attached | => DarkRadiant master 254d9c10 |
| 17.01.2024 19:54 | orbweaver | Status | assigned => resolved |
| 17.01.2024 19:54 | orbweaver | Resolution | open => fixed |
| 17.01.2024 19:54 | orbweaver | Fixed in Version | => 3.9.0 |
| 17.01.2024 19:54 | orbweaver | Note Added: 0016378 | |
| 19.01.2024 10:08 | orbweaver | Changeset attached | => DarkRadiant master c08f33ae |
| 19.01.2024 10:08 | orbweaver | Changeset attached | => DarkRadiant master 3e4c6f5e |
| 19.01.2024 10:08 | orbweaver | Changeset attached | => DarkRadiant master 61879986 |
| 19.01.2024 10:08 | greebo | Changeset attached | => DarkRadiant master 530f7b1c |
