0006438: Update to libsgic++ 3.6 - The Dark Mod Bugtracker

ID	Project	Category	View Status	Date Submitted	Last Update

0006438	DarkRadiant	General	public	13.01.2024 08:02	13.01.2024 11:34

Reporter	greebo	Assigned To
Priority	normal	Severity	normal	Reproducibility	have not tried
Status	suspended	Resolution	open

Summary	0006438: Update to libsgic++ 3.6
Description	There seem to be a newer C++17 versions of the libsgic++ library out there for a while, let's try to migrate.
Tags	No tags attached.

greebo 13.01.2024 11:34 administrator ~0016363	We can't update right now, since the libsgic++ Ubuntu package is still at version 3.4, but DR needs version 3.6+. There's a method sigc::signal<void>::connect_first that has been added in 3.6, which is needed to migrate the DR sources. In DeclarationManager.cpp we add a signal slot to the front of the list, but the slots() interface is no longer available (connect_first is the required replacement in sigc++3)

DarkRadiant: libsigcpp3 b643407a 13.01.2024 08:04 greebo Details Diff	0006438: First slew of changes. sigc::signal<> template arguments are now using a more modern syntax, like std::function. sigc::mem_fun no longer accepts a raw pointer to bind to the object, use references instead.		Affected Issues 0006438
	mod - include/ibrush.h		Diff File
	mod - include/icameraview.h		Diff File
	mod - include/iclipboard.h		Diff File
	mod - include/icounter.h		Diff File
	mod - include/ideclmanager.h		Diff File
	mod - include/ieclass.h		Diff File
	mod - include/ieditstopwatch.h		Diff File
	mod - include/ientity.h		Diff File
	mod - include/ifavourites.h		Diff File
	mod - include/ifilesystem.h		Diff File
	mod - include/ifilter.h		Diff File
	mod - include/igl.h		Diff File
	mod - include/igrid.h		Diff File
	mod - include/igui.h		Diff File
	mod - include/ilayer.h		Diff File
	mod - include/imap.h		Diff File
	mod - include/imapmerge.h		Diff File
	mod - include/imodelcache.h		Diff File
	mod - include/imodule.h		Diff File
	mod - include/imru.h		Diff File
	mod - include/iparticles.h		Diff File
	mod - include/ipatch.h		Diff File
	mod - include/iregistry.h		Diff File
	mod - include/irender.h		Diff File
	mod - include/irenderableobject.h		Diff File
	mod - include/iscenegraph.h		Diff File
	mod - include/iscript.h		Diff File
	mod - include/iselectionset.h		Diff File
	mod - include/ishaderclipboard.h		Diff File
	mod - include/ishaders.h		Diff File
	mod - include/itexturetoolmodel.h		Diff File
	mod - include/modelskin.h		Diff File
	mod - include/ui/imainframe.h		Diff File
	mod - libs/decl/DeclarationBase.h		Diff File
	mod - libs/parser/ThreadedDefLoader.h		Diff File
	mod - libs/registry/CachedKey.h		Diff File
	mod - libs/registry/Widgets.h		Diff File
	mod - libs/registry/registry.h		Diff File
	mod - libs/render/RenderableGeometry.h		Diff File
	mod - libs/render/RenderableSurface.h		Diff File
	mod - libs/render/WindingRenderer.h		Diff File
	mod - libs/scene/merge/MergeOperationBase.cpp		Diff File
	mod - libs/scene/merge/MergeOperationBase.h		Diff File
	mod - libs/wxutil/dialog/AutoSaveRequestBlocker.h		Diff File
	mod - libs/wxutil/fsview/FileSystemView.cpp		Diff File
	mod - libs/wxutil/fsview/FileSystemView.h		Diff File
	mod - libs/wxutil/preview/ModelPreview.cpp		Diff File
	mod - libs/wxutil/preview/ModelPreview.h		Diff File
	mod - libs/wxutil/preview/RenderPreview.cpp		Diff File
	mod - plugins/dm.editing/MissionInfoEditDialog.cpp		Diff File
	mod - plugins/dm.editing/MissionReadmeDialog.cpp		Diff File
	mod - plugins/dm.gameconnection/GameConnection.cpp		Diff File
	mod - plugins/dm.gameconnection/GameConnection.h		Diff File
	mod - plugins/dm.gui/gui/Gui.cpp		Diff File
	mod - plugins/dm.gui/gui/Gui.h		Diff File
	mod - plugins/dm.gui/gui/GuiExpression.h		Diff File
	mod - plugins/dm.gui/plugin.cpp		Diff File
	mod - plugins/dm.objectives/Component.h		Diff File
	mod - plugins/script/ScriptingSystem.cpp		Diff File
	mod - plugins/script/ScriptingSystem.h		Diff File
	mod - plugins/sound/SoundManager.h		Diff File
	mod - plugins/vcs/ui/VcsStatus.cpp		Diff File
	mod - radiant/RadiantApp.cpp		Diff File
mod - radiant/camera/CamWnd.cpp		Diff File
mod - radiant/camera/CameraSettings.cpp		Diff File
mod - radiant/camera/CameraSettings.h		Diff File
mod - radiant/clipboard/ClipboardModule.cpp		Diff File
mod - radiant/clipboard/ClipboardModule.h		Diff File
mod - radiant/eventmanager/MouseToolManager.cpp		Diff File
mod - radiant/eventmanager/RegistryToggle.h		Diff File
mod - radiant/map/AutoSaveTimer.cpp		Diff File
mod - radiant/textool/TexTool.cpp		Diff File
mod - radiant/textool/TexToolModeToggles.h		Diff File
mod - radiant/ui/AutoSaveRequestHandler.h		Diff File
mod - radiant/ui/FileOverwriteConfirmationHandler.h		Diff File
mod - radiant/ui/FileSaveConfirmationHandler.h		Diff File
mod - radiant/ui/FileSelectionRequestHandler.h		Diff File
mod - radiant/ui/ManipulatorToggle.h		Diff File
mod - radiant/ui/MapFileProgressHandler.cpp		Diff File
mod - radiant/ui/SelectionModeToggle.h		Diff File
mod - radiant/ui/UserInterfaceModule.cpp		Diff File
mod - radiant/ui/colourscheme/ColourSchemeEditor.cpp		Diff File
mod - radiant/ui/colourscheme/ColourSchemeEditor.h		Diff File
mod - radiant/ui/common/DialogManager.cpp		Diff File
mod - radiant/ui/common/SkinChooser.cpp		Diff File
mod - radiant/ui/console/Console.cpp		Diff File
mod - radiant/ui/einspector/EntityInspector.cpp		Diff File
mod - radiant/ui/favourites/FavouritesBrowser.cpp		Diff File
mod - radiant/ui/favourites/FavouritesUserInterfaceModule.cpp		Diff File
mod - radiant/ui/findshader/FindShader.cpp		Diff File
mod - radiant/ui/layers/LayerControlPanel.cpp		Diff File
mod - radiant/ui/lightinspector/LightInspector.cpp		Diff File
mod - radiant/ui/mainframe/MainFrame.cpp		Diff File
mod - radiant/ui/mainframe/MainFrame.h		Diff File
mod - radiant/ui/mapselector/MapSelector.cpp		Diff File
mod - radiant/ui/materials/MaterialChooser.cpp		Diff File
mod - radiant/ui/materials/MaterialChooser.h		Diff File
mod - radiant/ui/materials/MaterialTreeView.cpp		Diff File
mod - radiant/ui/materials/editor/MaterialPreview.cpp		Diff File
mod - radiant/ui/materials/editor/MaterialPreview.h		Diff File
DarkRadiant: libsigcpp3 4bc95e74 13.01.2024 09:03 greebo Details Diff	0006438: Fix the remaining compilation issues		Affected Issues 0006438
	mod - include/ieclasscolours.h		Diff File
	mod - include/imap.h		Diff File
	mod - include/imapresource.h		Diff File
	mod - include/imodule.h		Diff File
	mod - include/iselection.h		Diff File
	mod - include/ishaders.h		Diff File
	mod - include/itexturetoolmodel.h		Diff File
	mod - libs/registry/adaptors.h		Diff File
	mod - libs/registry/registry.h		Diff File
	mod - radiant/ui/Documentation.cpp		Diff File
	mod - radiantcore/decl/DeclarationManager.cpp		Diff File
	mod - radiantcore/eclass/EClassColourManager.cpp		Diff File
	mod - radiantcore/eclass/EClassColourManager.h		Diff File
	mod - radiantcore/entity/KeyObserverMap.h		Diff File
	mod - radiantcore/map/Map.cpp		Diff File
	mod - radiantcore/map/Map.h		Diff File
	mod - radiantcore/map/MapPositionManager.cpp		Diff File
	mod - radiantcore/selection/RadiantSelectionSystem.cpp		Diff File
	mod - radiantcore/selection/RadiantSelectionSystem.h		Diff File
	mod - radiantcore/selection/textool/TextureToolSelectionSystem.cpp		Diff File
	mod - radiantcore/selection/textool/TextureToolSelectionSystem.h		Diff File
	mod - radiantcore/shaders/MaterialManager.cpp		Diff File
	mod - radiantcore/shaders/MaterialManager.h		Diff File
	mod - test/Entity.cpp		Diff File
DarkRadiant: libsigcpp3 bbc848f5 13.01.2024 09:04 greebo Details Diff	0006438: Require libsigc++ 3.0		Affected Issues 0006438
	mod - CMakeLists.txt		Diff File
DarkRadiant: libsigcpp3 d94ea359 13.01.2024 09:54 greebo Details Diff	0006438: Require libsigc++ 3.0		Affected Issues 0006438
	mod - README.md		Diff File

Date Modified	Username	Field	Change
13.01.2024 08:02	greebo	New Issue
13.01.2024 08:02	greebo	Assigned To	=> greebo
13.01.2024 08:02	greebo	Status	new => assigned
13.01.2024 09:04	greebo	Changeset attached	=> DarkRadiant libsigcpp3 b643407a
13.01.2024 09:04	greebo	Changeset attached	=> DarkRadiant libsigcpp3 4bc95e74
13.01.2024 09:04	greebo	Changeset attached	=> DarkRadiant libsigcpp3 bbc848f5
13.01.2024 09:55	greebo	Changeset attached	=> DarkRadiant libsigcpp3 d94ea359
13.01.2024 11:34	greebo	Assigned To	greebo =>
13.01.2024 11:34	greebo	Status	assigned => suspended
13.01.2024 11:34	greebo	Note Added: 0016363

View Issue Details

Activities

Related Changesets

Issue History