 |
Could an on-Linux dev take a look at this? Would be nice. |
 |
@datiswous: I found some issues with the save object, but it did not crash for me on 2.12 and I updated the issue with my findings. Can you reproduce the crash on the 2.12 release too? |
|
|
I just tried spawn atdm:playertools_savegame in 2.13, but couldn't find the thing. Maybe this doesn't work anymore. It's probably fixed anyway because I think it's related to a fix mentioned in this report: https://bugs.thedarkmod.com/view.php?id=4967#c16947 Mission Hazard Pay does not crash anymore in 2.13 on Linux |
 |
Autosave mod uses the same "savegame" script event, and it regularly generated corrupted savefile: https://forums.thedarkmod.com/index.php?/topic/23119-loading-saves-just-hangs-after-closereopen-the-game/ |
|
|
I believe the problem is caused by the fact that script event saves the game on frontend thread. It does try to delay the saving already, but it still does not do it at the right place. To fix this, I have simply rerouted the script event via "savegame" console command. It is much easier to delay-run console commands. r11197 Deleted "tdm_nosave" cvar from the code. r11198 Refactored console commands "savegame"/"loadgame", added "unrestricted" argument to savegame. r11199 Use "savegame" console command in delayed manner in "savegame" sctipt event, don't save the game immediately. r11200 Deleted "saveGameName" cvar state and "triggeredSave" game method. |
|
|
Strictly speaking, the text buffer for scheduled commands it global. So if we access it simultaneously from two threads, it can break. This commit should avoid this problem: r11201 Protected the global buffer for scheduled console commands with a mutex. |
- Anonymous
