 |
I can't get new objective at Belero. He falls down but the new objective does not come. If I still finish the rest of the steps despite no objective, everything finishes fine. UPDATE: It does not happen if I put the body, trigger the lift but remain downwards. If I remain on the moving lift, then it crashes. I'm pretty sure double triggering of "mission success" causes the crash. |
|
|
Ok, there are two objectives: 3: If Bellero is alive, get him back to the City. (mandatory) 11: DUMMY Is player at an exit? (NOT mandatory) When me and Belero are both on the lift, first objective 3 is marked complete. At this point CMissionData::Event_ObjectiveComplete checks all the objectives, sees that all mandatory ones are finished and calls Event_MissionComplete. Soon afterwards objective 11 is marked complete. CMissionData::Event_ObjectiveComplete again rechecks all objectives, sees that again all mandatory ones are finished and calls Event_MissionComplete again. It seems after when mission is finished, there is a few seconds of gameplay time. If some other objective (optional one) gets complete at this moment, then the "win" is triggered second time, which can cause this crash. |
|
|
Fixed in svn rev 10646. I simply blocked Event_MissionFailed and Event_MissionComplete if either of them has been called before. The sad consequence is that it you win a mission but then quickly lose (e.g. kill when you are not allowed to), you'll still get the win outcome. I think that's OK in general =) Now the interesting part. I noticed that sometimes the win objectives don't trigger while lift is moving up. Usually I can achieve it this way: 1) Load savegame where player is near the elevator and Belero is lying nearby. 2) Kill Belero with sword, check that mission is failed. 3) Load savegame again. 4) Shoulder Belero, go to elevator, drop body, trigger elevator, move up along with Belero's body. 5) Elevator is on top and stop moving, no objective has triggered during the lift movement. Now if I try to move down on the lift, the game crashes (something wrong with locations). But if I kill Belero with my sword, then I get a lot of objectives triggered! The first ones are objectives 3 and 11, i.e. the win objectives that were missed while the lift was moving. The failed objective of killing Belero comes next. So with my new fix, I still get the Mission Success afterwards =) |
 |
I made a mistake with step 5 in the steps-to-reproduce section. I just changed it from "new objective" to "objective complete". |
- Anonymous
