View Issue Details

IDProjectCategoryView StatusLast Update
0000065DarkRadiantGUIpublic08.02.2007 17:24
Reportergreebo Assigned Toorbweaver  
PriorityhighSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Product Version0.9.0 
Fixed in Version0.9.0 
Summary0000065: Skin Chooser crashes on open
DescriptionStart DarkRadiant, load a map with an AI (maybe this works with other models as well) in it, select the entity, add the Skin Property via right-click ("Add property") to the model and try to change the skin key/value by clicking on the ellipsis button. DarkRadiant bails out before the Skin chooser appears.
TagsNo tags attached.

Activities

greebo

greebo

28.01.2007 08:11

administrator   ~0000034

I can confirm this at least on my Windows machine. Trying to add a skin property on any model and choosing a skin crashes as well. The bug is also on latest SVN (oerlay_plugin branch, but I guess the trunk has it too).
greebo

greebo

28.01.2007 08:24

administrator   ~0000035

The crash is located somewhere in SkinChooser::populateSkins(). Investigating further...
greebo

greebo

28.01.2007 08:32

administrator   ~0000036

The call GlobalModelSkinCache().getSkinsForModel(_model); is crashing and the program never reaches the module method getSkinsForModel(). Maybe there is some module reference missing.
greebo

greebo

28.01.2007 08:36

administrator   ~0000037

Yep. Adding a GlobalModelSkinCacheModuleRef resolved the error, I will look where to elegantly put this.
greebo

greebo

28.01.2007 08:47

administrator   ~0000038

Fixed on latest SVN.
greebo

greebo

28.01.2007 08:59

administrator   ~0000039

Last edited: 28.01.2007 09:02

I reopened it, because there seems to exist another problem:

Go to maze1.map and select the AI in the upper left corner (top view) and try to give it a skin. The following message appears:

Assertion failed: px != 0, file boost.w32/include/boost/shared_ptr.hpp, line 253

It's probably located in the getSkinsForModel() method as well. This is reproducible with the AI mercenary elite too (just create the entity and try to give it a skin).

greebo

greebo

28.01.2007 09:59

administrator   ~0000040

The error occurs for me at this line in SkinChooser::showAndBlock():

gtk_widget_show_all(_widget);

although this may also be wrong... I'm stuck here.
orbweaver

orbweaver

28.01.2007 10:27

developer   ~0000042

Confirmed, the Skin Chooser does not work for AI. On Linux my assertion failure is slightly more informative:

darkradiant: /usr/include/boost/shared_ptr.hpp:253: T* boost::shared_ptr<T>::operator->() const [with T = model::IModel]: Assertion `px != 0' failed.
orbweaver

orbweaver

28.01.2007 12:12

developer   ~0000043

Crash fixed in trunk, however the skin preview does not work for AI due to different handling of models and skins for DEF-based entities.

Issue History

Date Modified Username Field Change
28.01.2007 08:09 greebo New Issue
28.01.2007 08:11 greebo Note Added: 0000034
28.01.2007 08:11 greebo Status new => confirmed
28.01.2007 08:24 greebo Note Added: 0000035
28.01.2007 08:32 greebo Note Added: 0000036
28.01.2007 08:36 greebo Note Added: 0000037
28.01.2007 08:40 greebo Status confirmed => assigned
28.01.2007 08:40 greebo Assigned To => greebo
28.01.2007 08:47 greebo Status assigned => resolved
28.01.2007 08:47 greebo Fixed in Version => latest SVN
28.01.2007 08:47 greebo Resolution open => fixed
28.01.2007 08:47 greebo Note Added: 0000038
28.01.2007 08:57 greebo Assigned To greebo =>
28.01.2007 08:57 greebo Status resolved => confirmed
28.01.2007 08:57 greebo Resolution fixed => reopened
28.01.2007 08:57 greebo Product Version 0.8.0 => latest SVN
28.01.2007 08:59 greebo Note Added: 0000039
28.01.2007 09:02 greebo Note Edited: 0000039
28.01.2007 09:59 greebo Note Added: 0000040
28.01.2007 10:25 orbweaver Status confirmed => assigned
28.01.2007 10:25 orbweaver Assigned To => orbweaver
28.01.2007 10:27 orbweaver Note Added: 0000042
28.01.2007 12:12 orbweaver Status assigned => resolved
28.01.2007 12:12 orbweaver Resolution reopened => fixed
28.01.2007 12:12 orbweaver Note Added: 0000043
08.02.2007 17:24 orbweaver Status resolved => closed