Source Control Integration - The Dark Mod Bugtracker

master 72ec80fa 13.12.2022 21:12 orbweaver Details Diff	0006187: fix "Wrong type" error dialogs in Prefab Chooser on Linux The GTK treeview cell renderers do not support tree model cells returning no data (or data of the wrong type), and show this "Wrong type" dialog as a consequence. This was a problem in the Prefab Chooser because certain rows do not contain the full range of data (e.g. the root node and folder nodes do not have a "size" value). (Note that there was never any problem with entire columns not being displayed, or with hidden columns missing data. But if a column is displayed and has a cell renderer attached, that cell renderer expects to receive valid data for every row). The implementation of TreeModel::GetValue() is now updated to return a default wxVariant in the case of model nodes which do not contain an explicit value for the requested column. For string and numeric column types (which are all rendered as string data), this is just an empty wxString(), so there is no visible change in the GUI.		Affected Issues 0006187
	mod - libs/wxutil/dataview/TreeModel.cpp		Diff File
master 465e0c54 07.12.2022 20:40 orbweaver Details Diff	0006187: direct wxWidgets log messages to stderr on Linux The default behaviour of popping up a series of modal dialog boxes is possibly the most unhelpful way of showing errors imaginable. On Linux we now use wxLogStderr to direct these log messages to stderr. On Windows the behaviour is left as-is because stderr isn't usually accessible; the ideal solution might be to direct the log messages to the in-application Console window but this would require a custom wxLog implementation.		Affected Issues 0006187
	mod - radiant/RadiantApp.cpp		Diff File
master 19f9c1ea 07.12.2022 20:36 orbweaver Details Diff	0006187: use inline default initialisation for PrefabSelector members		Affected Issues 0006187
	mod - radiant/ui/prefabselector/PrefabSelector.cpp		Diff File
	mod - radiant/ui/prefabselector/PrefabSelector.h		Diff File
master 5363c1c2 30.11.2022 20:34 orbweaver Details Diff	0006178: ArtProvider is now local to RadiantApp class LocalBitmapArtProvider was only ever constructed and owned by RadiantApp; the reason it was exposed as a wxutil header was for the ArtIdPrefix() method, which was used in a single other header (Bitmap.h). LocalBitmapArtProvider is now RadiantApp::ArtProvider, a local nested class which is not exposed anywhere else. The functions in Bitmap.h just use the "darkradiant:" prefix explicitly, which could be seen as duplication but (1) the prefix is very unlikely to change, and (2) the redundancy isn't serious enough to justify exposing the art provider class and its method(s) through several headers and their dependent shared objects. Also removed the LocalBitmapArtProvider destructor which explicitly removed the art provider from wxWidgets. This appeared to be redundant because the wxArtProvider base class already does this in its own destructor (according to documentation).		Affected Issues 0006178
	mod - libs/wxutil/Bitmap.h		Diff File
	rm - libs/wxutil/LocalBitmapArtProvider.h		Diff
	mod - radiant/RadiantApp.cpp		Diff File
	mod - radiant/RadiantApp.h		Diff File
	mod - radiant/ui/materials/editor/MaterialEditor.cpp		Diff File
	mod - radiant/ui/skin/SkinEditor.cpp		Diff File
	mod - radiant/xyview/GlobalXYWnd.cpp		Diff File
master dc63b7c4 29.11.2022 21:11 orbweaver Details Diff	0006178: fix potentially uninitialised matrices in XYWnd This seems to be the last of the Valgrind warnings that appear before the main window is shown, other than those which appear in third-party code (e.g. wxWidgets) and probably aren't fixable on our side.		Affected Issues 0006178
	mod - radiant/xyview/XYWnd.cpp		Diff File
	mod - radiant/xyview/XYWnd.h		Diff File
master c8fe8ce0 29.11.2022 21:01 orbweaver Details Diff	0006178: fix a couple more uninitialised values		Affected Issues 0006178
	mod - libs/wxutil/ConsoleView.h		Diff File
	mod - radiant/ui/texturebrowser/TextureThumbnailBrowser.h		Diff File
master 59ec3282 29.11.2022 20:32 orbweaver Details Diff	0006178: avoid potential use of initialised size vector in TextureThumbnailBrowser Valgrind flagged up a possible "jump based on uninitialised value", which appeared to be caused by the _viewportSize vector in TextureThumbnailBrowser. This vector was left uninitialised at construction, and subsequently set to a real value after receiving a wxEVT_SIZE event, which is not guaranteed to happen. The _viewportSize value is now an std::optional which is initialised on demand when the getViewportSize() private method is called (as well as being updated by the wxEVT_SIZE event as before).		Affected Issues 0006178
	mod - radiant/ui/texturebrowser/TextureBrowserPanel.cpp		Diff File
	mod - radiant/ui/texturebrowser/TextureThumbnailBrowser.cpp		Diff File
	mod - radiant/ui/texturebrowser/TextureThumbnailBrowser.h		Diff File
master 751cd7ad 23.11.2022 21:21 orbweaver Details Diff	0006178: LocalBitmapArtProvider uses wxBitmap::LoadFile() The previous approach of constructing a wxBitmap from a temporary wxImage was leading to an uninitialised data warning in Valgrind, although it does not seem to be related to the assertion on shutdown (which still appears after this change).		Affected Issues 0006178
	mod - libs/wxutil/LocalBitmapArtProvider.h		Diff File
master da8002c3 23.11.2022 20:52 orbweaver Details Diff	0006178: DEBUG_CULLING is disabled by default This is triggering a lot of uninitialised value errors in Valgrind (of uncertain cause), and is unlikely to be useful for development tasks that don't specifically relate to culling.		Affected Issues 0006178
	mod - libs/render/View.h		Diff File
master 99a57a22 23.11.2022 08:48 greebo Details Diff	Increase VCS status timeout to 5 seconds, it can be expensive to check the map status using the git index
	mod - plugins/vcs/ui/VcsStatus.cpp		Diff File
master d9145c30 22.11.2022 22:57 jonri Committer: GitHub Details Diff	Bump version in metainfo
	mod - install/net.darkradiant.DarkRadiant.metainfo.xml		Diff File
master 0020a73b 22.11.2022 20:49 orbweaver Details Diff	Merge remote-tracking branch 'greebo/master'
	mod - .github/workflows/build.yml		Diff File
	mod - CMakeLists.txt		Diff File
	mod - PKGBUILD		Diff File
	mod - include/ideclmanager.h		Diff File
	mod - include/ientity.h		Diff File
	mod - include/modelskin.h		Diff File
	mod - include/ui/ientityinspector.h		Diff File
	mod - include/version.h		Diff File
	mod - install/menu.xml		Diff File
	add - install/ui/skineditor.fbp		Diff File
	add - install/ui/skineditor.xrc		Diff File
	mod - install/user.xml		Diff File
	add - libs/decl/DeclLib.h		Diff File
	mod - libs/parser/DefBlockSyntaxParser.h		Diff File
	mod - libs/selection/EntitySelection.h		Diff File
	mod - libs/wxutil/PanedPosition.cpp		Diff File
	mod - libs/wxutil/dataview/ThreadedDeclarationTreePopulator.h		Diff File
	mod - libs/wxutil/dataview/TreeView.cpp		Diff File
	mod - libs/wxutil/dataview/TreeView.h		Diff File
	mod - libs/wxutil/preview/EntityPreview.cpp		Diff File
	mod - libs/wxutil/preview/ModelPreview.cpp		Diff File
	mod - libs/wxutil/preview/ModelPreview.h		Diff File
	mod - plugins/dm.editing/AIHeadPropertyEditor.cpp		Diff File
	mod - plugins/dm.editing/AIHeadPropertyEditor.h		Diff File
	mod - plugins/dm.editing/AIVocalSetPropertyEditor.cpp		Diff File
	mod - plugins/dm.editing/AIVocalSetPropertyEditor.h		Diff File
	mod - plugins/dm.gameconnection/GameConnection.cpp		Diff File
	mod - plugins/vcs/Repository.cpp		Diff File
	add - plugins/vcs/Signature.h		Diff File
	mod - plugins/vcs/ui/VcsStatus.cpp		Diff File
	mod - radiant/CMakeLists.txt		Diff File
	mod - radiant/ui/Documentation.cpp		Diff File
	mod - radiant/ui/Documentation.h		Diff File
	mod - radiant/ui/UserInterfaceModule.cpp		Diff File
	mod - radiant/ui/einspector/AnglePropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/BooleanPropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/ClassnamePropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/ColourPropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/EntityInspector.cpp		Diff File
	mod - radiant/ui/einspector/EntityInspector.h		Diff File
	mod - radiant/ui/einspector/EntityPropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/FloatPropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/FxPropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/ModelPropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/PropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/PropertyEditor.h		Diff File
	mod - radiant/ui/einspector/SkinPropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/SoundPropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/TexturePropertyEditor.cpp		Diff File
	mod - radiant/ui/einspector/Vector3PropertyEditor.cpp		Diff File
	mod - radiant/ui/entitylist/EntityList.cpp		Diff File
	mod - radiant/ui/entitylist/EntityList.h		Diff File
	mod - radiant/ui/entitylist/GraphTreeModel.cpp		Diff File
	mod - radiant/ui/entitylist/GraphTreeModel.h		Diff File
	mod - radiant/ui/entitylist/GraphTreeModelPopulator.h		Diff File
	mod - radiant/ui/entitylist/GraphTreeNode.h		Diff File
	mod - radiant/ui/fx/FxChooser.cpp		Diff File
	mod - radiant/ui/mainframe/AuiLayout.cpp		Diff File
	mod - radiant/ui/mainframe/AuiManager.cpp		Diff File
	mod - radiant/ui/mainframe/PropertyNotebook.cpp		Diff File
	mod - radiant/ui/mainframe/PropertyNotebook.h		Diff File
	mod - radiant/ui/materials/MaterialSelector.cpp		Diff File
	mod - radiant/ui/materials/MaterialSelector.h		Diff File
mod - radiant/ui/modelselector/ModelSelector.cpp		Diff File
mod - radiant/ui/script/ScriptWindow.cpp		Diff File
mod - radiant/ui/script/ScriptWindow.h		Diff File
add - radiant/ui/skin/MaterialSelectorColumn.h		Diff File
add - radiant/ui/skin/SkinEditor.cpp		Diff File
add - radiant/ui/skin/SkinEditor.h		Diff File
add - radiant/ui/skin/SkinEditorTreeView.cpp		Diff File
add - radiant/ui/skin/SkinEditorTreeView.h		Diff File
mod - radiantcore/CMakeLists.txt		Diff File
mod - radiantcore/decl/DeclarationManager.cpp		Diff File
mod - radiantcore/decl/DeclarationManager.h		Diff File
mod - radiantcore/entity/curve/Curve.cpp		Diff File
mod - radiantcore/entity/curve/Curve.h		Diff File
mod - radiantcore/entity/curve/RenderableCurveVertices.h		Diff File
mod - radiantcore/entity/doom3group/StaticGeometryNode.cpp		Diff File
mod - radiantcore/map/Map.cpp		Diff File
mod - radiantcore/map/MapResource.cpp		Diff File
mod - radiantcore/rendersystem/backend/ColourShader.cpp		Diff File
mod - radiantcore/rendersystem/backend/ColourShader.h		Diff File
mod - radiantcore/selection/algorithm/Curves.cpp		Diff File
mod - radiantcore/shaders/CShader.cpp		Diff File
mod - radiantcore/shaders/MaterialManager.cpp		Diff File
mod - radiantcore/shaders/MaterialManager.h		Diff File
add - radiantcore/skins/Doom3ModelSkin.cpp		Diff File
mod - radiantcore/skins/Doom3ModelSkin.h		Diff File
mod - radiantcore/skins/Doom3SkinCache.cpp		Diff File
mod - radiantcore/skins/Doom3SkinCache.h		Diff File
mod - test/CMakeLists.txt		Diff File
add - test/Curves.cpp		Diff File
mod - test/DeclManager.cpp		Diff File
mod - test/DefBlockSyntaxParser.cpp		Diff File
mod - test/Entity.cpp		Diff File
mod - test/Selection.cpp		Diff File
mod - test/Skin.cpp		Diff File
add - test/algorithm/Selection.h		Diff File
add - test/resources/tdm/maps/splines.map		Diff File
mod - test/resources/tdm/skins/test_skins.skin		Diff File
master fd8d6d0f 22.11.2022 07:54 greebo Details Diff	Generic colour shaders are adjusting themselves to merge mode rendering
	mod - radiantcore/rendersystem/backend/ColourShader.cpp		Diff File
master 68c68687 22.11.2022 07:46 greebo Details Diff	Disable per-node vertex colouring in merge mode, this is controlled by the shader
	mod - radiantcore/rendersystem/backend/ColourShader.cpp		Diff File
	mod - radiantcore/rendersystem/backend/ColourShader.h		Diff File
master b665ddc3 22.11.2022 05:38 greebo Details Diff	Fix a resource leak in the VCS plugin. Give the VCS status bar a bit more space.
	mod - plugins/vcs/Repository.cpp		Diff File
	add - plugins/vcs/Signature.h		Diff File
	mod - plugins/vcs/ui/VcsStatus.cpp		Diff File
	mod - tools/msvc/vcs.vcxproj		Diff File
	mod - tools/msvc/vcs.vcxproj.filters		Diff File
master 6b4c68ef 22.11.2022 05:01 greebo Details Diff	Bump Setup-VSTest@v1.2 version to 1.2 to fix node deprecation warning
	mod - .github/workflows/build.yml		Diff File
master dcfcac78 22.11.2022 04:59 greebo Details Diff	0006162: Newly (unsaved) created skins will have the replacement list populated from the model automatically on selection Added models will be loaded into the model preview.		Affected Issues 0006162
	mod - radiant/ui/skin/SkinEditor.cpp		Diff File
	mod - radiant/ui/skin/SkinEditor.h		Diff File
master f948ec79 22.11.2022 04:50 greebo Details Diff	0006162: Activate edited remapping rows for convenience		Affected Issues 0006162
	mod - radiant/ui/skin/SkinEditor.cpp		Diff File
master 6e4f5ca7 22.11.2022 04:17 greebo Details Diff	0006158: Fix the unrotatable model in the preview, the func_static has to consider itself a model, which is determined by the "model" key value		Affected Issues 0006158
	mod - libs/wxutil/preview/ModelPreview.cpp		Diff File
master 29de0b46 21.11.2022 17:51 greebo Details Diff	0006162: Fix crashes due to open column editor controls		Affected Issues 0006162
	mod - libs/wxutil/dataview/TreeView.cpp		Diff File
	mod - radiant/ui/skin/SkinEditor.cpp		Diff File
master 24de467b 21.11.2022 17:39 greebo Details Diff	0006174: Fix exception leak, even the destructor of the MapExporter might throw if map progress messages are sent		Affected Issues 0006174
	mod - plugins/dm.gameconnection/GameConnection.cpp		Diff File
	mod - radiantcore/map/Map.cpp		Diff File
	mod - radiantcore/map/MapResource.cpp		Diff File
master 2204fe17 18.11.2022 17:23 greebo Details Diff	0006173: Fix DefBlockSyntaxTokeniserFunc to deal with quotes within comments		Affected Issues 0006173
	mod - libs/parser/DefBlockSyntaxParser.h		Diff File
	mod - test/DefBlockSyntaxParser.cpp		Diff File
master 2329d409 18.11.2022 15:14 greebo Details Diff	0006173: Add unit test covering the problematic sequences		Affected Issues 0006173
	mod - test/DefBlockSyntaxParser.cpp		Diff File
master 2a142071 18.11.2022 09:58 greebo Details Diff	0006166: Fix crashes due to the _selection container getting out of date (due to idle processing of selections) Remove the dangerous _selection container and replace it with a simpler approach. Performance issue when click-selecting items in the entity list are rather unlikely.		Affected Issues 0006166
	mod - radiant/ui/entitylist/EntityList.cpp		Diff File
	mod - radiant/ui/entitylist/EntityList.h		Diff File
master 57c84066 18.11.2022 08:00 greebo Details Diff	Bump version
	mod - CMakeLists.txt		Diff File
	mod - PKGBUILD		Diff File
	mod - include/version.h		Diff File

Changesets: DarkRadiant