Changesets: DarkRadiant

master ed5dc937

22.05.2021 06:48

greebo


Details Diff
0005555: Disable map save progress dialog when updating entities Affected Issues
0005555
mod - plugins/dm.gameconnection/GameConnection.cpp Diff File

master 66c3df0f

22.05.2021 06:36

greebo


Details Diff
0005555: Avoid double-entering the think() method from external triggers (wxTimer).
The lock cannot be placed within the GameConnection::think() body, since think is recursively calling itself by design.
Affected Issues
0005555
mod - plugins/dm.gameconnection/GameConnection.cpp Diff File
mod - plugins/dm.gameconnection/GameConnection.h Diff File

master dfc0ae4f

19.05.2021 20:09

orbweaver


Details Diff
Confirm PointTrace can return correct point positions

PointTrace has a new method points() which returns the point vector, which is
now examined in the unit test.
Affected Issues
0005603
mod - libs/scene/PointTrace.h Diff File
mod - test/PointTrace.cpp Diff File

master 66b3c078

19.05.2021 19:35

orbweaver


Details Diff
Remove hard-coded text colouring in Entity Inspector

The hard-coded colours assumed a light background, but the default black text
is very difficult to see with a dark theme applied. Instead of forcing colours
to distinguish entity properties from inherited properties, we now render the
inherited properties in italic text while leaving colours to be chosen by the
theme.
mod - radiant/ui/einspector/EntityInspector.cpp Diff File

master 884043d3

18.05.2021 20:13

orbweaver


Details Diff
forEachPointfile() sorts pointfile names

Sorting the names lexicographically should ensure that <mapname>.lin is always
first in the list, so the actual leak pointfile will take precedence over any
visportal pointfiles.
Affected Issues
0005603
mod - radiantcore/map/Map.cpp Diff File

master 2690984f

18.05.2021 20:05

orbweaver


Details Diff
PointFile::parse() makes use of forEachPointfile()

Since there is not yet any selection GUI, the first pointfile found is used.
Currently the pointfile order is undefined if there is more than one present.
Affected Issues
0005603
mod - radiantcore/map/PointFile.cpp Diff File

master dc165ce7

18.05.2021 19:46

orbweaver


Details Diff
Test enumerated pointfiles have correct names

PointfileFunctor now accepts fs::path references rather than bare std::strings,
and this information is now recorded and examined in the unit test to ensure
the returned pointfiles have the correct filenames (ignoring parent paths).
Affected Issues
0005603
mod - include/imap.h Diff File
mod - test/PointTrace.cpp Diff File

master e1072c83

18.05.2021 19:33

orbweaver


Details Diff
Test that pointfiles are not returned for an unrelated map

This test actually provoked a bug in the forEachPointfile() method, which was
not checking if the map directory actually existed before constructing a
directory_iterator, possibly resulting in an exception.
Affected Issues
0005603
mod - radiantcore/map/Map.cpp Diff File
mod - test/PointTrace.cpp Diff File

master b75c4f20

13.05.2021 17:05

greebo


Details Diff
0005607: Make sure the render system is realised by the time we initialise the preview. Affected Issues
0005607
mod - libs/wxutil/preview/RenderPreview.cpp Diff File

master a88849ef

13.05.2021 17:02

greebo


Details Diff
0005609: When realising the render system in the constructor, give the code a chance to invoke extensionsInitialised() first.
The extensionsInitialised() call will query the GL setup for the ability to use GL programs, which should preferably be known before we realise the OpenGLShader objects.
Affected Issues
0005609
mod - radiantcore/rendersystem/OpenGLRenderSystem.cpp Diff File

master b83c3d72

13.05.2021 17:00

greebo


Details Diff
0005607: In case the rendersystem is not realised yet the contained material in the Shader object will be empty - don't crash when rendering MD5 models in such a situation Affected Issues
0005607
mod - radiantcore/model/md5/MD5ModelNode.cpp Diff File

master 9fc9017c

12.05.2021 20:22

orbweaver


Details Diff
Functional implementation of forEachPointfile()

Method uses fs::directory_iterator to enumerate files in the directory
containing the map file, and looks for any file with a .lin extension and a
stem which corresponds to the map name (with a possible underscore suffix).
Unit test now passes as a result.
Affected Issues
0005603
mod - radiantcore/map/Map.cpp Diff File

master 41764665

12.05.2021 19:20

orbweaver


Details Diff
PointTraceTest now uses the RadiantTest fixture Affected Issues
0005603
mod - test/PointTrace.cpp Diff File

master 6c3af511

11.05.2021 19:42

orbweaver


Details Diff
Add two test .lin files for the altar.map example

Test now fails because there should be two pointfiles enumerated with
forEachPointfile().
Affected Issues
0005603
mod - test/PointTrace.cpp Diff File
add - test/resources/tdm/maps/altar.lin Diff File
add - test/resources/tdm/maps/altar_portalL_544_64_112.lin Diff File

master bf131e1e

11.05.2021 19:38

orbweaver


Details Diff
Initial IMap::forEachPointfile() method to enumerate pointfiles

New method with a unit test which is currently trivial because the method does
not yet do anything.
Affected Issues
0005603
mod - include/imap.h Diff File
mod - radiantcore/map/Map.cpp Diff File
mod - radiantcore/map/Map.h Diff File
mod - test/PointTrace.cpp Diff File

master 9f575515

06.05.2021 19:52

orbweaver


Details Diff
Test constructing PointTrace with empty data Affected Issues
0005603
mod - test/PointTrace.cpp Diff File

master ece03600

06.05.2021 19:36

orbweaver


Details Diff
Initial PointTrace class with test

Add a PointTrace class which can parse pointfile data from a std::istream and
construct a vector of point positions. This class is unit tested but not yet
used by the existing PointFile code.
Affected Issues
0005603
add - libs/scene/PointTrace.h Diff File
mod - test/CMakeLists.txt Diff File
add - test/PointTrace.cpp Diff File

master ece0da82

05.05.2021 17:53

greebo


Details Diff
0005602: Add material editor section to doom3.game to prevent it from crashing Affected Issues
0005602
mod - install/games/doom3.game Diff File

master 5615ecc3

04.05.2021 18:33

orbweaver


Details Diff
Install new resources for Material Editor

Without the bundled resources (test cube, room background etc) the Material
Editor just shows an empty preview or a "Shader not found" cube.
mod - CMakeLists.txt Diff File
mod - debian/changelog Diff File

master 9b3b8371

03.05.2021 18:46

orbweaver


Details Diff
Add libeigen3-dev to build dependencies
mod - debian/changelog Diff File
mod - debian/control Diff File

master 9bdae99c

03.05.2021 14:02

orbweaver


Details Diff
Skip tests in debian package build

93% of the tests are working after the libradiantcore path changes, but some of
them fail when trying to save and load data in /tmp. Rather than spend more
time debugging this, the tests are just skipped in the debian package build
(the tests are there for developers to check changes before committing, so it's
not terribly important to run them in a package build).
mod - debian/rules Diff File

master afef8aee

03.05.2021 13:44

orbweaver


Details Diff
Add another relative path for radiantcore in tests

Running drtest directly from the build directory without installing to the
prefix (as dpkg-buildpackage does) requires a third search path for the
radiantcore module. This one is calculated relative to the drtest binary rather
than any compiled-in path.
mod - test/TestContext.h Diff File

master 6eb16092

03.05.2021 12:44

orbweaver


Details Diff
Add 2.12.0 to debian/changelog
mod - debian/changelog Diff File
mod - debian/control Diff File

master 1d995375

03.05.2021 12:31

orbweaver


Details Diff
Fix tests in out-of-source CMake build

We can't assume that the built core module can be found in the
./test/../radiantcore directory, because with an out-of-source build the shared
libraries do not appear in the source directory at all. With a separate build
directory we need the old behaviour of looking in PKGLIBDIR/modules, however
this doesn't work with in-source builds.

Fortunately getLibraryPaths() returns a list of directories, so we can just add
both possibilities to the list and get functional tests with both in-source and
out-of-source builds.
mod - test/TestContext.h Diff File

master 10a853ec

03.05.2021 11:16

orbweaver


Details Diff
Rethrow exception if RadiantTest initialisation fails

No point in continuing with a possibly null core module pointer, which will
just create segfaults later.
mod - test/RadiantTest.h Diff File
 First  Prev  1 2 3 ... 30 ... 60 ... 90 ... 120 ... 131 132 133 134 135 136 137 ... 150 ... 180 ... 210 ... 240 ... 264 265 266  Next  Last