Changesets: DarkRadiant
declmanager 8acdb354 03.07.2022 12:25 Details Diff |
0005977: Move eclass-related tests to separate test fixture, the Entity test was getting a bit crowded |
Affected Issues 0005977 |
|
mod - test/CMakeLists.txt | Diff File | ||
mod - test/Entity.cpp | Diff File | ||
add - test/EntityClass.cpp | Diff File | ||
mod - tools/msvc/Tests/Tests.vcxproj | Diff File | ||
mod - tools/msvc/Tests/Tests.vcxproj.filters | Diff File | ||
declmanager bb462bd5 03.07.2022 06:46 Details Diff |
0005977: Setting the model path on the entity class will alter the isFixedSize flag, so reactivate the code in the EClassParser for the moment being. |
Affected Issues 0005977 |
|
mod - include/ieclass.h | Diff File | ||
mod - radiantcore/eclass/EClassParser.cpp | Diff File | ||
mod - radiantcore/eclass/EntityClass.h | Diff File | ||
declmanager cee506b9 03.07.2022 06:42 Details Diff |
0005977: Remove the isFixedSize parameter altogether, it's now false by default in the only constructor that's left. |
Affected Issues 0005977 |
|
mod - radiantcore/eclass/EClassParser.cpp | Diff File | ||
mod - radiantcore/eclass/EntityClass.cpp | Diff File | ||
mod - radiantcore/eclass/EntityClass.h | Diff File | ||
declmanager 3fa9acb0 03.07.2022 06:39 Details Diff |
0005977: All client code is passing false to the isFixedSize argument, remove the argument and hardcode the argument in EntityClass:CreateDefault. |
Affected Issues 0005977 |
|
mod - radiantcore/eclass/DefCreators.h | Diff File | ||
mod - radiantcore/eclass/EClassManager.cpp | Diff File | ||
mod - radiantcore/eclass/EntityClass.cpp | Diff File | ||
mod - radiantcore/eclass/EntityClass.h | Diff File | ||
declmanager fdc6ccdb 03.07.2022 06:32 Details Diff |
0005977: Merge the two EntityClass constructors into one, since it's only used internally. Invert the bool logic of the named CreateDefault constructor to be the same as the one used in the regular constructor. The isFixedSize parameter is now mandatory on the EntityClass constructor. |
Affected Issues 0005977 |
|
mod - radiantcore/eclass/DefCreators.h | Diff File | ||
mod - radiantcore/eclass/EClassManager.cpp | Diff File | ||
mod - radiantcore/eclass/EClassParser.cpp | Diff File | ||
mod - radiantcore/eclass/EntityClass.cpp | Diff File | ||
mod - radiantcore/eclass/EntityClass.h | Diff File | ||
declmanager 697f588b 03.07.2022 05:45 Details Diff |
0005977: It seems the IEntityClass::getModelPath and getSkin methods were updated but never used by anything else => deactivating that code for now. Since the engine code deals with skins defined on modelDefs, let's open a separate bugtracker entry to support skinned model defs. |
Affected Issues 0005977 |
|
mod - include/ieclass.h | Diff File | ||
mod - radiantcore/eclass/EClassParser.cpp | Diff File | ||
mod - radiantcore/eclass/EntityClass.cpp | Diff File | ||
mod - radiantcore/eclass/EntityClass.h | Diff File | ||
declmanager fbfa5e99 02.07.2022 15:19 Details Diff |
0005977: Add IDeclarationManager::findOrCreateDeclaration to interface |
Affected Issues 0005977 |
|
mod - include/ideclmanager.h | Diff File | ||
mod - radiantcore/decl/DeclarationManager.cpp | Diff File | ||
mod - radiantcore/decl/DeclarationManager.h | Diff File | ||
mod - test/DeclManager.cpp | Diff File | ||
declmanager b1d2e0e5 02.07.2022 12:32 Details Diff |
0005977: Extend unit tests to cover more eclass colour override behaviour |
Affected Issues 0005977 |
|
mod - test/Entity.cpp | Diff File | ||
declmanager f30807cc 02.07.2022 10:15 Details Diff |
0005977: DeclarationManager treats decl names case-insensitively during lookup |
Affected Issues 0005977 |
|
mod - include/ideclmanager.h | Diff File | ||
mod - radiantcore/decl/DeclarationManager.h | Diff File | ||
declmanager 3250f2b0 02.07.2022 08:25 Details Diff |
0005977: Cleanup. Add more unit tests to prove that declaration lookup is case-insensitive. They are failing of course. |
Affected Issues 0005977 |
|
mod - radiantcore/eclass/EClassParser.cpp | Diff File | ||
mod - test/DeclManager.cpp | Diff File | ||
mod - test/Entity.cpp | Diff File | ||
declmanager a8c9a7c8 02.07.2022 08:05 Details Diff |
0005977: ModelDefs are now lazily parsing their contents, inheritance resolution is done on the fly. |
Affected Issues 0005977 |
|
mod - radiantcore/eclass/Doom3ModelDef.h | Diff File | ||
declmanager 0461d6f9 02.07.2022 06:07 Details Diff |
0005977: Redefine IModelDef interface to allow for lazy parsing of the declaration syntax |
Affected Issues 0005977 |
|
mod - include/ieclass.h | Diff File | ||
mod - plugins/script/interfaces/EClassInterface.cpp | Diff File | ||
mod - plugins/script/interfaces/EClassInterface.h | Diff File | ||
mod - radiant/ui/animationpreview/MD5AnimationViewer.cpp | Diff File | ||
mod - radiant/ui/animationpreview/MD5AnimationViewer.h | Diff File | ||
mod - radiant/ui/modelselector/ModelPopulator.h | Diff File | ||
mod - radiant/ui/modelselector/ModelSelector.cpp | Diff File | ||
mod - radiantcore/eclass/Doom3ModelDef.h | Diff File | ||
mod - radiantcore/eclass/EClassManager.cpp | Diff File | ||
mod - radiantcore/eclass/EClassManager.h | Diff File | ||
mod - radiantcore/eclass/EClassParser.cpp | Diff File | ||
mod - radiantcore/eclass/EClassParser.h | Diff File | ||
mod - radiantcore/model/ModelCache.cpp | Diff File | ||
mod - radiantcore/selection/algorithm/Entity.cpp | Diff File | ||
mod - test/Entity.cpp | Diff File | ||
declmanager 6eaa14e5 02.07.2022 05:11 Details Diff |
0005977: Set up some modelDef inheritance tests |
Affected Issues 0005977 |
|
mod - test/Entity.cpp | Diff File | ||
mod - test/resources/tdm/def/entity_with_model.def | Diff File | ||
declmanager 334067ad 02.07.2022 04:30 Details Diff |
0005977: Adjust modelDef parsing code to only deal with the block contents found in the decl. |
Affected Issues 0005977 |
|
mod - radiantcore/eclass/Doom3ModelDef.h | Diff File | ||
mod - radiantcore/eclass/EClassParser.cpp | Diff File | ||
declmanager 7f92e5fe 02.07.2022 04:25 Details Diff |
0005977: Start migrating Doom3ModelDefs to derive from DeclarationBase, redirect eclass manager methods to the declaration manager. Add some unit tests covering the modelDef-related methods. |
Affected Issues 0005977 |
|
mod - include/ideclmanager.h | Diff File | ||
mod - include/idecltypes.h | Diff File | ||
mod - include/ieclass.h | Diff File | ||
mod - libs/DeclarationBase.h | Diff File | ||
mod - plugins/script/interfaces/EClassInterface.cpp | Diff File | ||
mod - plugins/script/interfaces/EClassInterface.h | Diff File | ||
mod - plugins/sound/SoundManager.cpp | Diff File | ||
mod - plugins/sound/SoundShader.cpp | Diff File | ||
mod - plugins/sound/SoundShader.h | Diff File | ||
mod - radiant/ui/animationpreview/MD5AnimationViewer.cpp | Diff File | ||
mod - radiant/ui/animationpreview/MD5AnimationViewer.h | Diff File | ||
mod - radiantcore/decl/DeclarationManager.cpp | Diff File | ||
mod - radiantcore/decl/DeclarationManager.h | Diff File | ||
add - radiantcore/eclass/DefCreators.h | Diff File | ||
mod - radiantcore/eclass/Doom3ModelDef.h | Diff File | ||
mod - radiantcore/eclass/EClassManager.cpp | Diff File | ||
mod - radiantcore/eclass/EClassManager.h | Diff File | ||
mod - radiantcore/eclass/EntityClass.h | Diff File | ||
mod - test/DeclManager.cpp | Diff File | ||
mod - test/Entity.cpp | Diff File | ||
mod - test/resources/tdm/def/entity_with_model.def | Diff File | ||
mod - tools/msvc/DarkRadiantCore.vcxproj | Diff File | ||
mod - tools/msvc/DarkRadiantCore.vcxproj.filters | Diff File | ||
master b7d87a44 29.06.2022 19:49 Details Diff |
0000401: add unit test for a command sequence Confirm that the execute() method can run a sequence of commands separated by semicolons. |
Affected Issues 0000410 |
|
mod - test/CommandSystem.cpp | Diff File | ||
master b21d09ac 29.06.2022 19:39 Details Diff |
0000410: add unit test for ICommandSystem::addWithCheck() Confirm that the canExecute() method returns the correct value based on the check function. |
Affected Issues 0000410 |
|
mod - include/icommandsystem.h | Diff File | ||
mod - test/CommandSystem.cpp | Diff File | ||
master ca727001 29.06.2022 19:08 Details Diff |
0000410: add a simple test for adding and executing a Command This simple command just increments a counter when it is called, so we can confirm that the registration and callback mechanism is working. |
Affected Issues 0000410 |
|
mod - test/CommandSystem.cpp | Diff File | ||
master 231ffcf4 29.06.2022 18:57 Details Diff |
0000410: skeleton test suite for the CommandManager Currently a single trivial test which confirms only that we can obtain the CommandManager module. |
Affected Issues 0000410 |
|
mod - libs/parser/Tokeniser.h | Diff File | ||
mod - test/CMakeLists.txt | Diff File | ||
add - test/CommandSystem.cpp | Diff File | ||
master 1f8842d0 28.06.2022 19:49 Details Diff |
0000410: add support for greying out menu items based on Statements Some menu items (such as Brush/Prism...) are based on Statements (commands with arguments) rather than simple Commands. This change implements the canExecute() method on Statement objects, allowing menu items such as Prism to be disabled if the underlying command is not runnable (ignoring arguments). The only menu items this change currently affects are the first three items in the Brush menu, which are all variants of the QueryBrushPrefabSidesDialog command with different arguments. |
Affected Issues 0000410 |
|
mod - include/icommandsystem.h | Diff File | ||
mod - libs/selectionlib.h | Diff File | ||
mod - radiant/ui/UserInterfaceModule.cpp | Diff File | ||
mod - radiantcore/brush/csg/CSG.cpp | Diff File | ||
mod - radiantcore/commandsystem/CommandSystem.cpp | Diff File | ||
mod - radiantcore/commandsystem/CommandSystem.h | Diff File | ||
mod - radiantcore/commandsystem/Executable.h | Diff File | ||
mod - radiantcore/commandsystem/Statement.h | Diff File | ||
declmanager 7077f397 26.06.2022 14:18 Details Diff |
0005977: Introduce DeclarationBase as base implementation of IDeclaration |
Affected Issues 0005977 |
|
add - libs/DeclarationBase.h | Diff File | ||
mod - plugins/sound/SoundShader.cpp | Diff File | ||
mod - plugins/sound/SoundShader.h | Diff File | ||
mod - tools/msvc/libs.vcxproj | Diff File | ||
mod - tools/msvc/libs.vcxproj.filters | Diff File | ||
declmanager a533214b 26.06.2022 10:51 Details Diff |
0005977: Add ReloadDecls which is now the target of the ReloadSounds command. Cleanup and comments. |
Affected Issues 0005977 |
|
mod - include/ideclmanager.h | Diff File | ||
mod - include/isound.h | Diff File | ||
mod - plugins/sound/SoundManager.cpp | Diff File | ||
mod - plugins/sound/SoundManager.h | Diff File | ||
mod - radiant/ui/common/SoundChooser.cpp | Diff File | ||
mod - radiantcore/decl/DeclarationManager.cpp | Diff File | ||
mod - radiantcore/decl/DeclarationManager.h | Diff File | ||
mod - test/DeclManager.cpp | Diff File | ||
declmanager 60dc9427 26.06.2022 10:31 Details Diff |
0005977: Simplify file extension replacement code a bit |
Affected Issues 0005977 |
|
mod - plugins/sound/SoundManager.cpp | Diff File | ||
mod - plugins/sound/SoundManager.h | Diff File | ||
declmanager fbb3e81e 26.06.2022 10:24 Details Diff |
0005977: Check SoundManager behaviour when serving requests for files without extensions |
Affected Issues 0005977 |
|
mod - test/SoundManager.cpp | Diff File | ||
declmanager f2032dfa 26.06.2022 10:17 Details Diff |
0005977: More SoundManager tests |
Affected Issues 0005977 |
|
mod - test/SoundManager.cpp | Diff File | ||
mod - test/resources/tdm/sound/parsing_test.sndshd | Diff File | ||
add - test/resources/tdm/sound/test/jorge.ogg | Diff File | ||
add - test/resources/tdm/sound/test/jorge.wav | Diff File |