Changesets: DarkRadiant

Search Browse Back to Index

master 60dba8cc

11.02.2025 20:14

orbweaver


Details Diff		 Remove unused method and fix some compiler warnings
mod - libs/render/RenderableCollectionWalker.h Diff File
mod - libs/render/RenderableCollectorBase.h Diff File
mod - radiantcore/model/StaticModel.cpp Diff File
mod - radiantcore/model/StaticModel.h Diff File
mod - radiantcore/rendersystem/OpenGLRenderSystem.h Diff File

master 0cc2ca0a

05.02.2025 19:59

orbweaver


Details Diff		 Remove C array cast from BasicVector2

As with Vector3, this required the removal of some '<' operators
defined in the Python API which relied on the meaningless comparison of
memory addresses.
mod - libs/math/Vector2.h Diff File
mod - libs/pybind/pybind11/operators.h Diff File
mod - plugins/script/interfaces/MathInterface.cpp Diff File
mod - radiantcore/selection/algorithm/Texturing.cpp Diff File
mod - test/math/Vector.cpp Diff File

master 51038811

04.02.2025 19:57

orbweaver


Details Diff		 BasicVector4 no longer implicitly casts to C array

Same treatment as for BasicVector3.
mod - libs/math/Vector3.h Diff File
mod - libs/math/Vector4.h Diff File
mod - libs/wxutil/preview/GuiRenderer.cpp Diff File
mod - radiant/textool/TexTool.cpp Diff File
mod - radiantcore/rendersystem/backend/OpenGLState.h Diff File
mod - radiantcore/rendersystem/backend/TextRenderer.h Diff File
mod - radiantcore/rendersystem/backend/glprogram/InteractionProgram.cpp Diff File
mod - radiantcore/selection/textool/FaceNode.cpp Diff File
mod - radiantcore/selection/textool/Node.cpp Diff File
mod - radiantcore/selection/textool/PatchNode.cpp Diff File
mod - radiantcore/selection/textool/TextureToolRotateManipulator.cpp Diff File

master 0fef6252

29.01.2025 19:13

orbweaver


Details Diff		 BasicVector3 no longer implicitly casts to a C array

Remove the dangerous 'operator [const] T*' methods, replacing them with
explicit data() methods which can return a pointer to the storage, along
with operator[] to provide index-based lookup.

This also revealed that the cast to array was also being used (probably
inadvertently) to implement a couple of 'operator<' comparisons of
Vector3s, which is mathematically meaningless and semantically wrong,
because two identically-valued vectors would compare not equal. These
'operator<' methods did not appear to be used anywhere else so they have
been removed; this also removes the '__lt__' method implemented on the
Python Vector3 class.
mod - libs/math/Matrix3.h Diff File
mod - libs/math/Vector3.h Diff File
mod - libs/render/MeshVertex.h Diff File
mod - libs/render/VertexCb.h Diff File
mod - libs/wxutil/preview/RenderPreview.cpp Diff File
mod - plugins/script/interfaces/MathInterface.cpp Diff File
mod - radiant/camera/CamWnd.cpp Diff File
mod - radiant/selection/SelectionMouseTools.cpp Diff File
mod - radiant/xyview/OrthoView.cpp Diff File
mod - radiantcore/clipper/ClipPoint.cpp Diff File
mod - radiantcore/rendersystem/backend/TextRenderer.h Diff File
mod - radiantcore/selection/textool/TextureToolRotateManipulator.cpp Diff File
mod - test/Selection.cpp Diff File
mod - test/math/Vector.cpp Diff File

master 74cc6f97

28.01.2025 20:31

orbweaver


Details Diff		 Fix a failing selection test

"Vector3(x, y, z) + 20" looks like it should perform a scalar addition
of 20 to the Vector3 elements, but it does not: there is no operator+
defined which takes a Vector3 and a scalar. What this actually does is
implicitly cast the Vector3 to a double*, perform pointer arithmetic on
the result, then construct a new Vector3 with whatever random garbage
happens to be at the invalid memory location.

For now the test is fixed locally, but this implicit cast to a raw
pointer is obviously extremely dangerous and needs to be fixed in the
Vector classes themselves.
mod - test/Selection.cpp Diff File

master 94964a5f

22.01.2025 19:52

orbweaver


Details Diff		 VCS (Git) module is an optional plugin, not a core module

Unit tests now pass when run from the build directory, apart from one of
the OrthoViewSelectionTests which was already failing.
mod - plugins/vcs/CMakeLists.txt Diff File

master 3a0f84ce

21.01.2025 21:00

orbweaver


Details Diff		 Place optional plugins in correct subdirectory

Optional TDM plugins need to go into lib/darkradiant/plugins, not
lib/darkradiant/modules.
mod - CMakeLists.txt Diff File
mod - plugins/dm.conversation/CMakeLists.txt Diff File
mod - plugins/dm.difficulty/CMakeLists.txt Diff File
mod - plugins/dm.editing/CMakeLists.txt Diff File
mod - plugins/dm.gameconnection/CMakeLists.txt Diff File
mod - plugins/dm.gui/CMakeLists.txt Diff File
mod - plugins/dm.objectives/CMakeLists.txt Diff File
mod - plugins/dm.stimresponse/CMakeLists.txt Diff File
mod - radiantcore/modulesystem/ModuleRegistry.cpp Diff File

master 1e68203b

21.01.2025 20:29

orbweaver


Details Diff		 InstanceReference no longer dereferences a null pointer

The tests still do not run correctly from inside build/darkradiant, but
at least they now fail rather than segfault.
mod - include/imodule.h Diff File

master 97214aeb

21.01.2025 19:24

orbweaver


Details Diff		 Install non-executable resources into staging area

DarkRadiant is now runnable from inside ${CMAKE_BINARY_DIR} immediately
after building, without requiring an install step to a different
location. This enables run/debug functionality in a CMake-aware IDE to
work as expected without further configuration. However the tests are
crashing due to some module loading issue.
mod - CMakeLists.txt Diff File
add - install.cmake Diff File
mod - radiant/CMakeLists.txt Diff File

master 1836ff8b

19.01.2025 16:50

orbweaver


Details Diff		 Initial changes to create a staging installation under build dir

Adjust the output directory of binary and library CMake targets to
create an installation tree under "${CMAKE_BINARY_DIR}/darkradiant",
with the aim of allowing the built application to be directly run from
within an IDE without requiring a separate "make install" step.

The main binary and modules/plugins are moved to the new location, but
the staged installation is not yet runnable because resources from the
"install" directory are not yet being copied in.
mod - CMakeLists.txt Diff File
mod - plugins/dm.conversation/CMakeLists.txt Diff File
mod - plugins/dm.difficulty/CMakeLists.txt Diff File
mod - plugins/dm.editing/CMakeLists.txt Diff File
mod - plugins/dm.gameconnection/CMakeLists.txt Diff File
mod - plugins/dm.gui/CMakeLists.txt Diff File
mod - plugins/dm.objectives/CMakeLists.txt Diff File
mod - plugins/dm.stimresponse/CMakeLists.txt Diff File
mod - plugins/script/CMakeLists.txt Diff File
mod - plugins/sound/CMakeLists.txt Diff File
mod - plugins/vcs/CMakeLists.txt Diff File
mod - radiantcore/CMakeLists.txt Diff File

master 94167d3a

07.01.2025 19:36

orbweaver


Details Diff		 Streamline [De]ActivateAllFilters commands

Commands call back-end method directly; intermediate command removed;
unused public method(s) removed.
mod - include/ifilter.h Diff File
mod - radiantcore/filters/BasicFilterSystem.cpp Diff File
mod - radiantcore/filters/BasicFilterSystem.h Diff File

master a500a749

18.12.2024 19:53

orbweaver


Details Diff		 Add initial unit test for SceneFilter
mod - libs/scene/filters/SceneFilter.cpp Diff File
mod - libs/scene/filters/SceneFilter.h Diff File
mod - test/Filters.cpp Diff File

master cf027c45

10.12.2024 20:05

orbweaver


Details Diff		 XMLFilter is now SceneFilter

Other than being stored in the XML registry (along with all other
settings), these filter objects really have nothing to do with XML. Also
move the class into the scene library for ease of unit testing.
mod - libs/scene/CMakeLists.txt Diff File
mv - radiantcore/filters/XMLFilter.cpp → libs/scene/filters/SceneFilter.cpp Diff File
mv - radiantcore/filters/XMLFilter.h → libs/scene/filters/SceneFilter.h Diff File
mod - radiantcore/CMakeLists.txt Diff File
mod - radiantcore/filters/BasicFilterSystem.cpp Diff File
mod - radiantcore/filters/BasicFilterSystem.h Diff File
mod - radiantcore/filters/SetObjectSelectionByFilterWalker.h Diff File
mod - radiantcore/filters/XmlFilterEventAdapter.cpp Diff File
mod - radiantcore/filters/XmlFilterEventAdapter.h Diff File
mod - tools/msvc/DarkRadiantCore.vcxproj Diff File
mod - tools/msvc/DarkRadiantCore.vcxproj.filters Diff File
mod - tools/xcode/DarkRadiant.xcodeproj/project.pbxproj Diff File

master fedf6d7a

10.12.2024 19:38

orbweaver


Details Diff		 Reduce number of console messages emitted from FontLoader
mod - radiantcore/fonts/FontLoader.h Diff File
mod - radiantcore/fonts/GlyphSet.cpp Diff File

master be4a96e6

04.12.2024 19:28

orbweaver


Details Diff		 Remove CallSuper antipattern from RenderPreview::setupSceneGraph()

setupSceneGraph() is now an empty virtual method which subclasses are
free to override or not as they wish (all of them do, except
MapPreview).

The single line in the original default implementation (setting the
current render time to 0) is now moved up into the calling method, so
that subclasses are no longer required to call the parent implementation
to avoid breaking the base class behaviour.
mod - libs/wxutil/menu/FilterPopupMenu.cpp Diff File
mod - libs/wxutil/menu/FilterPopupMenu.h Diff File
mod - libs/wxutil/menu/PopupMenu.cpp Diff File
mod - libs/wxutil/menu/PopupMenu.h Diff File
mod - libs/wxutil/preview/EntityPreview.cpp Diff File
mod - libs/wxutil/preview/ParticlePreview.cpp Diff File
mod - libs/wxutil/preview/RenderPreview.cpp Diff File
mod - libs/wxutil/preview/RenderPreview.h Diff File
mod - radiant/ui/animationpreview/AnimationPreview.cpp Diff File
mod - radiant/ui/common/MapPreview.h Diff File
mod - radiant/ui/materials/editor/MaterialPreview.cpp Diff File
mod - radiant/ui/modelselector/ModelTreeView.cpp Diff File
mod - radiantcore/filters/BasicFilterSystem.h Diff File

master 74a669f9

03.12.2024 19:50

orbweaver


Details Diff		 0003821: cleanup various linter warnings

Remove various redundant includes; also switch to inline initialisation
of several class members.		 Affected Issues
0003821
mod - libs/wxutil/preview/EntityClassPreview.h Diff File
mod - libs/wxutil/preview/EntityPreview.cpp Diff File
mod - libs/wxutil/preview/EntityPreview.h Diff File
mod - libs/wxutil/preview/ModelPreview.cpp Diff File
mod - libs/wxutil/preview/ModelPreview.h Diff File
mod - libs/wxutil/preview/RenderPreview.cpp Diff File
mod - libs/wxutil/preview/RenderPreview.h Diff File
mod - radiant/ui/modelselector/ModelSelector.cpp Diff File
mod - radiant/ui/modelselector/ModelSelector.h Diff File

master 9743b77c

27.11.2024 20:00

orbweaver


Details Diff		 Update FilterEditor screenshot in manual
mod - doc/img/FilterEditor.png Diff File

master f02e1f81

27.11.2024 19:55

orbweaver


Details Diff		 Update DifficultyEditor screenshot in manual
mod - doc/img/DifficultyEditor.png Diff File

master d5fee210

20.11.2024 19:48

orbweaver


Details Diff		 Use icons on buttons in Difficulty dialog

Also update the "refresh" icon with a flatter appearance.
mod - install/bitmaps/refresh.png Diff File
mod - install/ui/difficultyeditor.fbp Diff File
mod - install/ui/difficultyeditor.xrc Diff File
mod - plugins/dm.difficulty/DifficultyDialog.cpp Diff File
mod - plugins/dm.difficulty/DifficultyDialog.h Diff File
add - resources/icons/refresh.svg Diff File

master 9885e262

13.11.2024 19:38

orbweaver


Details Diff		 All buttons in Conversation Editor now using icons
add - install/bitmaps/trashcan.png Diff File
mod - install/ui/conversationdialog.fbp Diff File
mod - install/ui/conversationdialog.xrc Diff File
mod - install/ui/conversationeditor.fbp Diff File
mod - install/ui/conversationeditor.xrc Diff File
mod - plugins/dm.conversation/CommandEditor.cpp Diff File
add - resources/icons/trashcan.svg Diff File

master 1b649206

06.11.2024 19:50

orbweaver


Details Diff		 Add icons for Copy and View in filter dialog
add - install/bitmaps/copy.png Diff File
add - install/bitmaps/view.png Diff File
mod - install/ui/filterdialog.fbp Diff File
mod - install/ui/filterdialog.xrc Diff File
mod - install/ui/filtereditor.fbp Diff File
mod - install/ui/filtereditor.xrc Diff File
add - resources/icons/copy.svg Diff File
add - resources/icons/view.svg Diff File

master a8083bee

06.11.2024 19:37

orbweaver


Details Diff		 Use icons for some buttons in filter dialog(s)
mod - install/ui/filterdialog.fbp Diff File
mod - install/ui/filterdialog.xrc Diff File
mod - install/ui/filtereditor.fbp Diff File
mod - install/ui/filtereditor.xrc Diff File

master 303219dd

05.11.2024 20:02

orbweaver


Details Diff		 Replace "Edit" icon
mod - install/bitmaps/edit.png Diff File
add - resources/icons/edit.svg Diff File

master b817325f

05.11.2024 19:44

orbweaver


Details Diff		 Fix sizing issues in Filter Editor
mod - install/ui/filtereditor.fbp Diff File
mod - install/ui/filtereditor.xrc Diff File
mod - radiant/ui/filters/editor/FilterEditor.cpp Diff File

master a8273ac2

05.11.2024 19:30

orbweaver


Details Diff		 Add icon for "Validate all" in ConversationEditor
add - install/bitmaps/validate_actors.png Diff File
mod - install/ui/conversationeditor.fbp Diff File
mod - install/ui/conversationeditor.xrc Diff File
add - resources/icons/validate_actors.svg Diff File
 First  Prev  1 2 3 4 5 6 7 8 9 ... 30 ... 60 ... 90 ... 120 ... 150 ... 180 ... 210 ... 240 ... 270 271 272  Next  Last