Changesets: DarkRadiant

master 2cbe0648

15.12.2021 20:47

orbweaver


Details Diff
0005836: avoid unwanted colour changes when adjusting multiple lights

This appears to be a long-standing bug with the LightInspector. The
multi-selection code is far too coercive, setting ALL properties from the
dialog on ALL selected lights, rather than just the property which has changed.

This commit fixes the unwanted colour changes when toggling multiple lights
between omni and projected, but the bug still exists in other areas.
Affected Issues
0005836
mod - radiant/ui/lightinspector/LightInspector.cpp Diff File
mod - radiant/ui/lightinspector/LightInspector.h Diff File

master 122a87a5

14.12.2021 21:00

orbweaver


Details Diff
add/removeKeyObserver methods removed from EntityNode

Everything is using observeKey() now with auto-disconnection via
sigc::trackable, so there is no longer a need for these manual methods.
mod - include/ientity.h Diff File
mod - radiantcore/entity/EntityNode.cpp Diff File
mod - radiantcore/entity/EntityNode.h Diff File
mod - test/Entity.cpp Diff File

master eb9cea2d

14.12.2021 20:49

orbweaver


Details Diff
EntityNode uses observeKey() with auto-disconnection
mod - radiantcore/entity/EntityNode.cpp Diff File
mod - radiantcore/entity/EntityNode.h Diff File
mod - radiantcore/entity/ModelKey.h Diff File

renderer2 3957655a

14.12.2021 15:19

greebo


Details Diff
0005584: Highlight rendering of selected curves Affected Issues
0005584
mod - radiantcore/entity/curve/Curve.cpp Diff File
mod - radiantcore/entity/curve/Curve.h Diff File
mod - radiantcore/entity/doom3group/Doom3GroupNode.cpp Diff File
mod - radiantcore/entity/doom3group/Doom3GroupNode.h Diff File

renderer2 596f52cf

14.12.2021 12:55

greebo


Details Diff
0005584: Fix speaker geometry staying behind after closing the map Affected Issues
0005584
mod - radiantcore/entity/speaker/SpeakerNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerNode.h Diff File

renderer2 bafdbaf4

14.12.2021 12:46

greebo


Details Diff
0005584: Migrate Curve classes to use the RenderableGeometry base Affected Issues
0005584
mod - radiantcore/entity/curve/Curve.cpp Diff File
mod - radiantcore/entity/curve/Curve.h Diff File
mod - radiantcore/entity/curve/RenderableCurve.h Diff File
mod - radiantcore/entity/doom3group/Doom3GroupNode.cpp Diff File
mod - radiantcore/entity/doom3group/Doom3GroupNode.h Diff File

master b39db311

12.12.2021 19:37

orbweaver


Details Diff
EclassModelNode using observeKey() with auto-disconnection
mod - radiantcore/entity/eclassmodel/EclassModelNode.cpp Diff File
mod - radiantcore/entity/eclassmodel/EclassModelNode.h Diff File

master e0013abe

12.12.2021 19:21

orbweaver


Details Diff
Streamline storage of projected light colours and use flags

Local ProjectedVectors struct is now templated on its contained object type,
and is used for storing vectors, colours (also using Vector3) and usage flags
(bool).
mod - radiantcore/entity/light/Light.cpp Diff File
mod - radiantcore/entity/light/Light.h Diff File

master 47e24aee

12.12.2021 17:37

orbweaver


Details Diff
Streamline storage of projected light vectors

Instead of separate _lightX and _lightXTransformed values, introduce a new
TransformedCopy templated class which stores both a 'base' and a 'transformed'
version of an arbitrary data structure.
add - libs/scene/TransformedCopy.h Diff File
mod - radiantcore/entity/light/Light.cpp Diff File
mod - radiantcore/entity/light/Light.h Diff File
mod - radiantcore/entity/light/LightNode.cpp Diff File

master 5f0aa8ef

12.12.2021 14:38

orbweaver


Details Diff
Light is now using observeKey() with auto-disconnection
mod - radiantcore/entity/light/Doom3LightRadius.h Diff File
mod - radiantcore/entity/light/Light.cpp Diff File
mod - radiantcore/entity/light/Light.h Diff File
mod - radiantcore/entity/light/LightShader.h Diff File

master 76addecd

12.12.2021 14:05

orbweaver


Details Diff
GenericEntityNode now uses observeKey() with auto-disconnection
mod - radiantcore/entity/AngleKey.h Diff File
mod - radiantcore/entity/generic/GenericEntityNode.cpp Diff File
mod - radiantcore/entity/generic/GenericEntityNode.h Diff File

renderer2 b88915d1

12.12.2021 03:54

greebo


Details Diff
0005584: Old RenderableArrow class and render method removed Affected Issues
0005584
mod - libs/entitylib.h Diff File
rm - radiantcore/entity/generic/RenderableArrow.h Diff

master 099252e0

11.12.2021 20:50

orbweaver


Details Diff
Use inline initialisation for SpeakerNode constant members

Reduce duplication in constructors by initialising constant members inline.
mod - radiantcore/entity/speaker/SpeakerNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerNode.h Diff File

master d0525670

11.12.2021 20:31

orbweaver


Details Diff
SpeakerNode is now using observeKey()

Remove KeyObserverDelegates, use observeKey() with auto-disconnection for all
relevant spawnargs.
mod - radiantcore/entity/speaker/SpeakerNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerNode.h Diff File

renderer2 6b3d266b

11.12.2021 18:07

greebo


Details Diff
0005584: Speaker sphere vertices and indices are set up Affected Issues
0005584
mod - radiantcore/entity/speaker/SpeakerRenderables.cpp Diff File

renderer2 9fbeff58

11.12.2021 17:24

greebo


Details Diff
0005584: Working on sphere rendering Affected Issues
0005584
mod - radiantcore/entity/speaker/SpeakerNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerNode.h Diff File
mod - radiantcore/entity/speaker/SpeakerRenderables.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerRenderables.h Diff File

master c198b591

11.12.2021 14:14

orbweaver


Details Diff
StaticGeometryNode uses auto-disconnection of key observers

Use observeKey() for all key observations, with sigc::mem_fun to ensure
that auto-disconnection can happen when the object is destroyed.
mod - radiantcore/entity/doom3group/StaticGeometryNode.cpp Diff File

renderer2 5b4f017b

11.12.2021 06:33

greebo


Details Diff
0005584: Move the onEntitySettingsChanged() method up one level.
This fixes the SpeakerNode radius not showing up when the "always show speaker radius" option is toggled.
Affected Issues
0005584
mod - radiantcore/entity/EntityModule.cpp Diff File
mod - radiantcore/entity/EntityNode.h Diff File
mod - radiantcore/entity/light/LightNode.cpp Diff File
mod - radiantcore/entity/light/LightNode.h Diff File
mod - radiantcore/entity/speaker/SpeakerNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerNode.h Diff File

renderer2 20b0c1e6

11.12.2021 06:28

greebo


Details Diff
0005584: Wireframe radii now shown properly Affected Issues
0005584
mod - radiantcore/entity/speaker/SpeakerRenderables.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerRenderables.h Diff File

renderer2 4e601152

11.12.2021 05:28

greebo


Details Diff
0005584: Set up all three circles to render in the orthoview Affected Issues
0005584
mod - radiantcore/entity/speaker/SpeakerNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerRenderables.cpp Diff File

renderer2 c4468258

11.12.2021 05:16

greebo


Details Diff
0005584: Fix speaker and light volumes not always being rendered on selection status change Affected Issues
0005584
mod - radiantcore/entity/light/LightNode.cpp Diff File
mod - radiantcore/entity/light/LightNode.h Diff File
mod - radiantcore/entity/speaker/SpeakerNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerNode.h Diff File

renderer2 dad2ec13

11.12.2021 05:07

greebo


Details Diff
0005584: WIP commit, working on getting the circle geometry Affected Issues
0005584
mod - libs/render.h Diff File
mod - radiantcore/entity/speaker/SpeakerNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerNode.h Diff File
mod - radiantcore/entity/speaker/SpeakerRenderables.cpp Diff File

renderer2 fce184ca

11.12.2021 04:26

greebo


Details Diff
0005584: Refactor circle render methods to accept VertexCb and ArbitraryMeshVertex.
The actual Vertex3f& reference is resolved by using template specialisations.
Affected Issues
0005584
mod - libs/pivot.h Diff File
mod - libs/render.h Diff File
mod - radiantcore/entity/speaker/SpeakerNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerNode.h Diff File
mod - radiantcore/entity/speaker/SpeakerRenderables.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerRenderables.h Diff File
mod - radiantcore/selection/manipulators/RotateManipulator.cpp Diff File
mod - radiantcore/selection/textool/TextureToolRotateManipulator.cpp Diff File

renderer2 a5851240

11.12.2021 03:21

greebo


Details Diff
0005584: Use a const AABB reference to construct the RenderableEntityBox.
This might cause troubles when the RenderableEntityBox owner is changed to a base class, or if virtualness is added to some signatures.
In this case, an approach to pass an interface or function object to retrieve the bounds and the world position on demand is probably safer.
Affected Issues
0005584
mod - radiantcore/entity/RenderableEntityBox.cpp Diff File
mod - radiantcore/entity/RenderableEntityBox.h Diff File
mod - radiantcore/entity/generic/GenericEntityNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerNode.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerNode.h Diff File
mod - radiantcore/entity/speaker/SpeakerRenderables.cpp Diff File
mod - radiantcore/entity/speaker/SpeakerRenderables.h Diff File

renderer2 5d2a1e1a

10.12.2021 12:49

greebo


Details Diff
0005584: Highlight rendering of GenericEntityNodes Affected Issues
0005584
mod - radiantcore/entity/generic/GenericEntityNode.cpp Diff File
mod - radiantcore/entity/generic/GenericEntityNode.h Diff File
 First  Prev  1 2 3 ... 30 ... 60 ... 86 87 88 89 90 91 92 ... 120 ... 150 ... 180 ... 210 ... 240 ... 270 271 272  Next  Last