 |
Confirmed long ago that there is a bug here: void idEntity::GetTeamChildren( idList<idEntity *> *list ) { // ishtvan: TODO: I think this is WRONG and can go up and across the team hierarchy when called on bind children // It only works as advertised when called on bindmasters. // grayman - ABSOLUTELY!!! This routine can wrongly tell you that your brothers and sisters are your children. idEntity *NextEnt = NULL; list->Clear(); for( NextEnt = GetNextTeamEntity(); NextEnt != NULL; NextEnt = NextEnt->GetNextTeamEntity() ) { if( NextEnt != this ) list->Append( NextEnt ); } } |
|
|
@stgatilov Even though this code was not changed, the "teamChain" code associated to GetNextTeamEntity was refactored in 0005409 to avoid bugs like this. Shall we mark this closed in 2.09? |
 |
I think this still works the same way: considers the whole team as a group and returns its tail in whatever order. That's by design, I suppose. Maybe add assert that it is called only for team roots? |
- Anonymous
