 |
I have reimplemented the teams/binds system in svn rev 8980. The old code can be enabled by setting cvar "g_entityBindNew 0" (non-archived). Looking through the code, it seems that the teamChain linked list should traverse through the whole tree of bound elements in PRE-ORDER traversal order: https://en.wikipedia.org/wiki/Tree_traversal#Pre-order_(NLR) (just there can be any number of sons, not always two) This was clearly the intent of the authors, but it was not properly maintained on entity unbinding. The QuitTeam method was the culprit: such method must not exist at all. With the new implementation, this invariant is strongly maintained. Only two methods which can change the structure of bind tree and team linked list are: EstablishBindToMaster BreakBindToMaster In debug build, both of them check the invariant before and after modification (calling the ValidateBindTeam method). As a side effect, I have broken movers with nonempty "team" spawnarg. For now such cases cause immediate Error, since I think/hope they do not exist. |
|
|
Noticed that keys in StLucia FM were bound to legs of guards (instead of hips) =) It turned out that the new code dropped bindJoint/bindBody information during binding. idEntity::FinishBind called BreakBindToMaster, which cleared these two members. But they are set BEFORE calling FinishBind. So now I don't clear these members in BreakBindToMaster. Instead, I explicitly clear them in idEntity::Unbind. Committed in svn rev 9033. |
- Anonymous
