View Issue Details

IDProjectCategoryView StatusLast Update
0003944The Dark ModGraphicspublic14.09.2019 14:04
ReporterSteveL Assigned ToSteveL  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
Product VersionTDM 2.02 
Target VersionTDM 2.03Fixed in VersionTDM 2.03 
Summary0003944: Fix most water shaders so they don't distort foreground objects
DescriptionChild issue of 0003879: Warping post processes (water and glass) distort foreground objects

The same fix technique can be used for all the Heat Haze family of shaders, that provide refractive effects for glass, water, alabaster, potion bottles etc, but I'm splitting off this issue so I can commit fixed water for 2.03 and leave the rest for 2.04.

The 2.03 fix is for HeatHazeWithMask.vfp which is used in most water shaders.

Steps To ReproduceHold an object up in front of a pool of water and see its edges get dragged about by the water surface.
Additional InformationAdds _currentDepth texture to the list of fragment program inputs, so that the post-process shader can avoid taking samples from the foreground.

Unfortunately I can't just change the HeatHazeWithMask.vfp shader and fix it in all existing maps, because many maps use custom materials with this shader, and those material decls would need updating too.

Instead I'll add a new shader program HeatHazeWithMaskAndDepth.vfp, and I'll update the TDM core assets to use it, those found in:

tdm_textures_base01.pk4 -> materials/tdm_water.mtr
TagsNo tags attached.

Relationships

child of 0003879 resolvedSteveL Warping post processes (water and glass) distort foreground objects 

Activities

SteveL

SteveL

29.11.2014 22:14

developer   ~0007181

Last edited: 29.11.2014 22:24

View 4 revisions

Crossed tdm_models_decls01.pk4 -> materials/tdm_models_weapons.mtr [2 materials] off the list... arrow tips are not a problem afaik.

Also
tdm_textures_base01.pk4 -> materials/tdm_sfx_legacy.mtr [3 materials]
tdm_textures_base01.pk4 -> materials/tdm_ghouse_sfx.mtr [1 materials]

Those are deform_sprite materials and test textures, which I don't think we ever use. The only one I thought I needed to check was waterfall_effect, and only 1 map uses it and that's a custom version which wouldn't be affected by the fix anyway.

SteveL

SteveL

29.11.2014 22:31

developer   ~0007182

Last edited: 29.11.2014 22:32

View 2 revisions

Textures to be fixed and tested, all from tdm_textures_base01.pk4 -> materials/tdm_water.mtr:

textures/water_source/water_clear
textures/water_source/water_blurred
textures/water_source/water_stream
textures/water_source/water_stream_fast
textures/water_source/water_clear2
textures/water_source/water_clear3
textures/water_source/water_clear4
textures/water_source/water_green
textures/water_source/water_colored
textures/water_source/water_blue
textures/water_source/toxin
textures/water_source/neon
textures/water_source/water_dark
textures/water_source/blood_1
textures/water_source/cave_water_clear
textures/water_source/cave_water_muddy
textures/water_source/sea_water_01
textures/water_source/map_specific/galleon_water_overlay

These all use HeatHazeWithMask.vfp

SteveL

SteveL

29.11.2014 23:31

developer   ~0007183

committed at rev 14092

glprogs/HeatHazeWithmaskAndDepth.vfp
materials/tdm_water.mtr
stgatilov

stgatilov

14.09.2019 14:04

administrator   ~0011853

This material was touched but was not fixed correctly:
  textures/water_source/map_specific/galleon_water_overlay

Also, somewhere in 2017 Epifire added tdm_epi_shader2. It has the following materials using old shader:
  water_mist_001 (why without directories?...)
  steam_engine_heatwarp
  steam_engine_glassReadout
  steam_engine_glassReadoutOn

I wonder: should we do something about it?

Issue History

Date Modified Username Field Change
29.11.2014 17:50 SteveL New Issue
29.11.2014 17:50 SteveL Status new => assigned
29.11.2014 17:50 SteveL Assigned To => SteveL
29.11.2014 17:51 SteveL Relationship added child of 0003879
29.11.2014 17:52 SteveL Additional Information Updated View Revisions
29.11.2014 22:14 SteveL Note Added: 0007181
29.11.2014 22:14 SteveL Additional Information Updated View Revisions
29.11.2014 22:14 SteveL Note Edited: 0007181 View Revisions
29.11.2014 22:20 SteveL Note Edited: 0007181 View Revisions
29.11.2014 22:21 SteveL Additional Information Updated View Revisions
29.11.2014 22:23 SteveL Additional Information Updated View Revisions
29.11.2014 22:24 SteveL Note Edited: 0007181 View Revisions
29.11.2014 22:31 SteveL Note Added: 0007182
29.11.2014 22:32 SteveL Note Edited: 0007182 View Revisions
29.11.2014 23:31 SteveL Note Added: 0007183
29.11.2014 23:31 SteveL Status assigned => resolved
29.11.2014 23:31 SteveL Fixed in Version => TDM 2.03
29.11.2014 23:31 SteveL Resolution open => fixed
14.09.2019 14:04 stgatilov Note Added: 0011853