View Issue Details

IDProjectCategoryView StatusLast Update
0004684The Dark ModGraphicspublic30.12.2018 11:37
ReporterSpooks Assigned Tostgatilov  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
PlatformOSWindowsOS Version7
Product VersionSVN 
Target VersionTDM 2.07Fixed in VersionTDM 2.07 
Summary0004684: Graphical Artifacts in Warp Materials
DescriptionTransparent, warp materials (e.g. water, glass) exhibit graphical artifacts in 2.06. This only occurs when r_useFBO is set to 1 and even occurs when r_fboSharedDepth is set to 0.
Additional Informationhttp://forums.thedarkmod.com/topic/19162-beta-testing-206/page-7 (starting at post 153) contains discussion and screenshots of the artifacts.

To quote nbohr1more:

"This is an artifact from the use of FBO with "Shared Depth".
I'll have to play with cvars tonight to give a clear answer. Earlier in development you could cure this via r_fboSharedDepth 0
but it seems that Soft Shadows always causes this regardless of that setting in the latest builds."
TagsNo tags attached.

Relationships

related to 0003879 resolvedSteveL Warping post processes (water and glass) distort foreground objects 
related to 0004425 resolvedduzenko Framebuffer objects for color, depth, stencil 
related to 0004781 resolvednbohr1more Weird shimmering effect on seawater textures - 
related to 0004714 resolvedduzenko Water surfaces broken in Volta2 

Activities

duzenko

duzenko

25.11.2017 15:10

developer   ~0009701

I think that particular problem was fixed already.
(the test map with the fountain)
Spooks

Spooks

29.11.2017 22:18

reporter   ~0009715

That bug was described differently, assuming that the "15088 - water blur shader fixed (duzenko)" patch note in the latest beta package was it (0004671) being fixed, then no, this is a different issue.

I just started up TDM with said latest beta package and I can see the artifacting still occurring.
duzenko

duzenko

01.12.2017 20:39

developer   ~0009720

I would request a test map for this
Spooks

Spooks

02.12.2017 23:43

reporter  

warp.map (5,598 bytes)
Spooks

Spooks

02.12.2017 23:43

reporter   ~0009729

A test map has been added. There is a brush with a warp material in the map. As I said, toggling r_useFBO makes it easier to spot the difference in how that material renders.
duzenko

duzenko

03.12.2017 09:32

developer   ~0009730

Thanks. It appears the fix for "foreground objects distortion" is not compatible with the new FBO depth texture.

When I change the shader program for clear_warp from heathazewithdepth to heathaze it seems to fix it. Please confirm if that works for you.
Spooks

Spooks

03.12.2017 11:44

reporter   ~0009731

Yes, that makes the issue go away.
duzenko

duzenko

03.12.2017 16:11

developer   ~0009734

Other materials should be fixed in the same manner if needed
Springheel

Springheel

03.12.2017 17:35

administrator   ~0009735

Has the fix been tested to see if it reintroduces the foreground distortion that heathazewithdepth was introduced to solve?
duzenko

duzenko

06.12.2017 20:45

developer   ~0009741

It does not distort to me on the attached map but Spooks said it distorts for him.
duzenko

duzenko

08.12.2017 22:41

developer   ~0009748

Please attach a test map if distortion still occurs for you
duzenko

duzenko

21.12.2017 10:46

developer   ~0009863

Should the player weapon model be rendered _after_ models like clear_warp?
nbohr1more

nbohr1more

21.12.2017 17:21

developer   ~0009864

The problem affects more than the weapon and would produce erroneous effects
if (for example) you held a weapon behind glass or water that was closer to your eyes.

Anything in front of a warp\haze material is included in the effect.

SteveL's solution was to make the haze shader "depth aware" and stop it at discontinuity boundaries of foreground objects.

http://forums.thedarkmod.com/topic/15178-tdm-engine-development-page/page-13#entry356172
Spooks

Spooks

22.12.2018 08:52

reporter   ~0011013

Still present in 2.07 beta. In-game AA alleviates the issue.
nbohr1more

nbohr1more

28.12.2018 14:07

developer   ~0011158

2.07 Developement:

http://forums.thedarkmod.com/topic/19790-resolving-the-heathaze-problem/

Trunk rev 7868

Issue History

Date Modified Username Field Change
25.11.2017 15:08 Spooks New Issue
25.11.2017 15:10 duzenko Note Added: 0009701
29.11.2017 09:05 duzenko Assigned To => duzenko
29.11.2017 09:05 duzenko Status new => assigned
29.11.2017 22:18 Spooks Note Added: 0009715
01.12.2017 20:39 duzenko Note Added: 0009720
02.12.2017 23:43 Spooks File Added: warp.map
02.12.2017 23:43 Spooks Note Added: 0009729
03.12.2017 09:32 duzenko Note Added: 0009730
03.12.2017 11:44 Spooks Note Added: 0009731
03.12.2017 16:11 duzenko Note Added: 0009734
03.12.2017 16:11 duzenko Status assigned => resolved
03.12.2017 16:11 duzenko Fixed in Version => TDM 2.06
03.12.2017 16:11 duzenko Resolution open => fixed
03.12.2017 17:35 Springheel Note Added: 0009735
06.12.2017 20:45 duzenko Note Added: 0009741
08.12.2017 22:41 duzenko Note Added: 0009748
21.12.2017 10:46 duzenko Note Added: 0009863
21.12.2017 17:21 nbohr1more Note Added: 0009864
21.12.2017 17:21 nbohr1more Relationship added related to 0003879
26.12.2017 19:09 nbohr1more Relationship added related to 0004425
30.12.2017 19:35 grayman Target Version => TDM 2.06
29.04.2018 21:09 nbohr1more Relationship added related to 0004781
29.04.2018 21:10 nbohr1more Relationship added related to 0004714
22.12.2018 08:52 Spooks Note Added: 0011013
22.12.2018 08:52 Spooks Status resolved => feedback
22.12.2018 08:52 Spooks Resolution fixed => reopened
28.12.2018 14:07 nbohr1more Note Added: 0011158
28.12.2018 14:08 nbohr1more Assigned To duzenko => stgatilov
28.12.2018 14:08 nbohr1more Fixed in Version TDM 2.06 => TDM 2.07
28.12.2018 14:08 nbohr1more Target Version TDM 2.06 => TDM 2.07
30.12.2018 11:37 STiFU Status feedback => resolved
30.12.2018 11:37 STiFU Resolution reopened => fixed