 |
Please read the related issue 0004663, it contains a very lengthy discussion about the problem. The ideas for solutions include: second sensitivity for GUI, auto-detect sensitivity from windows, fetch absolute cursor coordinates from OS, etc. |
|
|
The suggested solutions are: 1. Add separate cvar "sensitivityGui" without menu slider, and fetch its value from Windows (SystemParametersInfo with SPI_GETMOUSESPEED). Probably it should be non-archiving cvar, so that it is reevaluated on every run, unless player has explicitly overriden it manually in .cfg-file. 2. Somehow use absolute coordinates when GUI is active. This may be a proper solution, but it needs a bit of refactoring and has more breaking potential. |
|
|
How it is handled in dhewm3: 1. In events.cpp+574, mouse events are recorded from SDL: case SDL_MOUSEMOTION: res.evType = SE_MOUSE; res.evValue = ev.motion.xrel; res.evValue2 = ev.motion.yrel; mouse_polls.Append(mouse_poll_t(M_DELTAX, ev.motion.xrel)); mouse_polls.Append(mouse_poll_t(M_DELTAY, ev.motion.yrel)); return res; 2. In UserInterface.cpp+344, mouse movements are scaled for menus based on resolution: if ( event->evType == SE_MOUSE ) { if ( !desktop || (desktop->GetFlags() & WIN_MENUGUI) ) { // DG: this is a fullscreen GUI, scale the mousedelta added to cursorX/Y // by 640/w, because the GUI pretends that everything is 640x480 // even if the actual resolution is higher => mouse moved too fast float w = renderSystem->GetScreenWidth(); float h = renderSystem->GetScreenHeight(); if( w <= 0.0f || h <= 0.0f ) { w = 640.0f; h = 480.0f; } cursorX += event->evValue * (640.0f/w); cursorY += event->evValue2 * (480.0f/h); } else { // not a fullscreen GUI but some ingame thing - no scaling needed cursorX += event->evValue; cursorY += event->evValue2; } |
|
|
Looking at SDL sources: 3. In video\windows\SDL_windowsevents.c + 478, SDL listens to WM_MOUSEMOVE event which returns absolute coordinates: case WM_MOUSEMOVE: { SDL_Mouse *mouse = SDL_GetMouse(); if (!mouse->relative_mode || mouse->relative_mode_warp) { SDL_MouseID mouseID = (((GetMessageExtraInfo() & MOUSEEVENTF_FROMTOUCH) == MOUSEEVENTF_FROMTOUCH) ? SDL_TOUCH_MOUSEID : 0); SDL_SendMouseMotion(data->window, mouseID, 0, GET_X_LPARAM(lParam), GET_Y_LPARAM(lParam)); if (isWin10FCUorNewer && mouseID != SDL_TOUCH_MOUSEID && mouse->relative_mode_warp) { /* To work around 0003931, Win10 bug introduced in Fall Creators Update, where SetCursorPos() (SDL_WarpMouseInWindow()) doesn't reliably generate mouse events anymore, after each windows mouse event generate a fake event for the middle of the window if relative_mode_warp is used */ int center_x = 0, center_y = 0; SDL_GetWindowSize(data->window, ¢er_x, ¢er_y); center_x /= 2; center_y /= 2; SDL_SendMouseMotion(data->window, mouseID, 0, center_x, center_y); } } } SDL seems to have some additional stuff like warping cursor (which breaks on newer Win10) and accumulation of subpixel movements when sensitibity is lower than 1.0. and yes, it is possible to change sensitivity as hint (separate for "normal" and "relative" modes). |
|
|
Committed the change from dhewm3 (point 2 above) in svn rev 7489. In my opinion, this is a good change: before it horizontal mouse movement was noticeably faster than vertical movement, now they are almost equal. The mouse speed seems the same if measured in screen pixels (but lower resolution allows you to cover the whole screen faster). In fact, now mouse speed is a bit slow for me. Duzenko, could you please check how is your high-DPI mouse? I guess you also have very high resolution, so high DPI on mouse and screen are related. |
|
|
I tried also to take mouse settings from Windows control panel as described here: https://stackoverflow.com/a/43538322/556899 It feels good with mouse acceleration: it is much easier to cover large distances with mouse. On the other hand, it is necessary to create a cvar like sensitivityMenu to make sure that if player has problems with sensitivity, we can workaround it. Now the question is: how to combine Control Panel settings with cvar? Options are: 1. Apply cvar multiplier on top of adjustments made according to CP settings. 2. Cvar takes effect if it is positive. if it is -1, then Control Panels settings takes effect. |
|
|
Ok, made two more commits: svn rev 7490 and svn rev 7491. Along with the Doom3-specific scaling fix from dhewm3 mentioned above, two more adjustments are done to mouse movement vector (in case of menu GUI): 1. OS-specific adjustments are applied using new function Sys_AdjustMouseMovement. These include: mouse sensitivity and mouse acceleration from Control Panel, and also DPI scaling in case of Windows 10. These OS-specific adjustments can be disabled be setting cvar "sensitivityMenuOverride 1". 2. The movement is multiplied by "sensitivityMenu" cvar. I hope that it won't be necessary because point 1 should be enough. But if someone still meets big trouble with mouse in menu, he can at least tweak it manually with this cvar. Note that among 3 commits (revs 7489-7451) the commit 7490 only adds new system function without affecting gameplay. So if the need arises to rollback these changes, rolling back 7451 and then 7489 is enough. |
|
|
The testing results for these changes are discussed here: http://forums.thedarkmod.com/topic/19515-mouse-sensitivity-in-menu-changes/ |
- Anonymous
