 |
Supposedly, this issue and related 0004768 can be tackled with a single change. |
 |
@stgatilov Is there more work to do here? |
|
|
Yes, I think TDM still links dinput8.lib, hence uses DirectInput. |
|
|
Svn 9535 replaces DI with WM for mouse input |
|
|
Svn rev 9536 |
|
|
Hey, please don't close issues! Unless they were created erroneously. If you finished an issue, mark it as "resolved". P.S. Here is one reason for it: closed issues are not displayed in issues search by default. |
|
|
@stgatilov, sorry, didn't know that |
|
|
I tested the new build. The very first obvious problem is that now mouse movements take "acceleration" into account. So when you move mouse slowly, it turns around slowly, but when you move it fast, then same displacement results in larger movement in-game. In the main menu, acceleration is applied twice: one comes from the new mouse handling, and the second one is emulated in GUI code. I'm afraid it must be fixed: first-person shooter with mouse acceleration is a terrible idea. |
|
|
I can't repeat this The GUI cursor seems to move the same distance for me as the physical device at its any speed |
|
|
Also, svn rev 9538 broke console commands for me. If I open console with Ctrl+Alt+Tilde and write random letters for a long enough time, they are inserted after the first letter instead of being appended to the end. If I open console with just Tilde (won't work on releases without cfg changes), then it works fine. |
|
|
Perhaps I don't fully understand the problem as I can't repeat this one either Soon enough the input fills up for me and no new chars are accepted |
|
|
Speaking of broken console. It happens because "pressed" state of Ctrl button remains true even though I have released the key. I logged WM_KEYDOWN and WM_KEYUP events as you handle them in Sys_StdKeyboardInput, and I see that keyup events are lost sometimes. Perhaps this is related to pressing many keys at once. |
|
|
This seems to resolve it: case WM_SYSKEYUP: idKeyInput::ClearStates(); break; |
|
|
Created discussion: https://forums.thedarkmod.com/index.php?/topic/21039-directinput-raw-input-and-glfw/ |
|
|
I had to revert all the changes from this branch (rev 9548): r9533 removing DirectInput This commit deals with mouse input Converted DI to window messages The only possible issue is support for mice with 4+ buttons. WinAPI has WM codes for MS mouse additional buttons but is it universal for all mouse... r9534 removing DirectInput Fixed broken build for tools r9536 removed DirectInput r9538 removing DirectInput Included the Alt/Ctrl keys in regular processing r9541 removed remaining .h imports and DI data structures r9543. Cleaning after DirectInput removal. Feel free to restore the changes back. Although I think it is worth discussing this with Cabalistic --- that's why I created a forum thread =) |
|
|
We decided that it is not worth it because: 1) There are many issues like acceleration, moving out of screen/window, etc. It is not easy to write replacement, but it is easy to break things. 2) Replacing input with GLFW (as done on Linux now) is another possibility, which would make this whole effort useless. 3) DirectInput is now in Windows SDK, which is always installed with MSVC today, so there is zero inconvenience from depending on it. |
- Anonymous
