View Issue Details

IDProjectCategoryView StatusLast Update
0005051The Dark ModDef / Setuppublic24.12.2022 10:14
ReporterVanishedOne Assigned ToDragofer  
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Product VersionTDM 2.07 
Target VersionTDM 2.11Fixed in VersionTDM 2.11 
Summary0005051: Inherited rotation gets automatically overwritten on door classes
DescriptionWhen you create a rotating door, the default rotation isn't just inherited but explicitly set to 0 90 0 for that entity. I think that's because atdm:mover_door includes "editor_setKeyValue rotate" "0 90 0".

Entity classes that inherit from atdm:mover_door sometimes set their own values for "rotate", but typically don't override "editor_setKeyValue rotate", so the value they set is never actually inherited by an entity unless the mapper deletes the spawnarg from the entity.

A particularly odd case is that of atdm:mover_metal_cabinetdoor_l and atdm:mover_metal_cabinetdoor_r. They do set an editor value for translate of 0 0 0, which is unnecessary. They don't set one for rotate, so they get the atdm:mover_door default. This overrides the value they do have for rotate - which is 0 0 100 for both, resulting in a completely wrong rotation. And since they're a left and right pair, it's obvious the same rotation can't be correct for both.
Additional InformationThe situation is better for sliding doors: atdm:mover_door_sliding sets the editor value to 0 0 0, and atdm:dresser_04_drawer supplies its own editor value for translation. atdm:mover_door_industrial01_grate also handles this correctly, though oddly enough it doesn't inherit from atdm:mover_door_sliding.
TagsNo tags attached.

Relationships

related to 0005497 closed Explicitly set "rotate" and "translate" in entityDefs of special doors 

Activities

Dragofer

Dragofer

24.12.2022 10:14

developer   ~0015632

Rev 16711
Made sure all entities that inherit from atdm:mover_door have both "rotate" and "editor_setKeyValue rotate" set. Also fixed a wrongly set axis of rotation on atdm:mover_metal_cabinetdoor_l / r

Issue History

Date Modified Username Field Change
09.09.2019 00:48 VanishedOne New Issue
09.09.2019 00:58 VanishedOne Description Updated
19.01.2021 19:02 Dragofer Assigned To => Dragofer
19.01.2021 19:02 Dragofer Status new => closed
19.01.2021 19:02 Dragofer Resolution open => won't fix
19.01.2021 19:06 Dragofer Relationship added related to 0005497
19.01.2021 23:14 VanishedOne Relationship replaced has duplicate 0005497
20.01.2021 06:18 Dragofer Relationship replaced related to 0005497
24.12.2022 10:14 Dragofer Note Added: 0015632
24.12.2022 10:14 Dragofer Status closed => resolved
24.12.2022 10:14 Dragofer Resolution won't fix => fixed
24.12.2022 10:14 Dragofer Fixed in Version => TDM 2.11
24.12.2022 10:14 Dragofer Target Version => TDM 2.11