View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005497 | The Dark Mod | Def / Setup | public | 19.01.2021 19:05 | 24.12.2022 10:15 |
Reporter | Dragofer | Assigned To | |||
Priority | low | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | no change required | ||
Product Version | TDM 2.08 | ||||
Summary | 0005497: Explicitly set "rotate" and "translate" in entityDefs of special doors | ||||
Description | 0005051 points out that since atdm:mover_door explicitly sets a value for "rotate", any door entities inheriting from this will also need to explicitly set a value, since their inherited value will get overriden. This is not currently the case for all doors. | ||||
Tags | No tags attached. | ||||
What 0005051 says is that some entity classes already *do* set their own "rotate" and "translate" spawnargs, but (my theory was) they're overridden by values which appear to be a result of "editor_setKeyValue rotate"/"editor_setKeyValue translate" inherited from the base classes. The rotation/translation spawnargs are 'explicit' in the entityDefs; they're overridden when the entities are created in DR. https://bugs.thedarkmod.com/view.php?id=5051#c13483 seems to recognise this but appears to have taken 0005051 as a proposal to remove the editor_setKeyValue spawnargs from the base classes. |
|
I know, this means inheriting entity doors also need to explicitly set "editor_setKeyValue" "rotate" so they overwrite the base door's "editor_setKeyValue" "rotate". I'd rather have the small handful of inheriting doors do this than move some very commonly used spawnargs ("rotate", "translate") into the inherited properties list. Especially new mappers need to have these easily available. So, atdm:mover_door: "rotate" "0 90 0" "editor_setKeyValue" "rotate" "0 90 0" atdm:mover_metal_cabinetdoor_l "rotate" "0 100 0" "editor_setKeyValue" "rotate" "0 100 0" Rather than So, atdm:mover_door: "rotate" "0 90 0" atdm:mover_metal_cabinetdoor_l "rotate" "0 100 0" "editor_setKeyValue" "rotate" "0 100 0" or even just So, atdm:mover_door: "rotate" "0 90 0" atdm:mover_metal_cabinetdoor_l "rotate" "0 100 0" |
|
Alright, I can see how your intention might be to have it solved as per the first set shown above. Given 5051's title I read it as the core problem to be fixed being that atdm:mover_door makes use of "editor_setKeyValue". | |
I seem to have misunderstood what 5051 was about. | |
Date Modified | Username | Field | Change |
---|---|---|---|
19.01.2021 19:05 | Dragofer | New Issue | |
19.01.2021 19:06 | Dragofer | Relationship added | related to 0005051 |
19.01.2021 23:13 | VanishedOne | Note Added: 0013486 | |
19.01.2021 23:14 | VanishedOne | Relationship replaced | duplicate of 0005051 |
20.01.2021 06:18 | Dragofer | Relationship replaced | related to 0005051 |
20.01.2021 06:22 | Dragofer | Note Added: 0013487 | |
20.01.2021 06:25 | Dragofer | Note Edited: 0013487 | |
20.01.2021 06:30 | Dragofer | Note Edited: 0013487 | |
20.01.2021 06:34 | Dragofer | Note Added: 0013488 | |
24.12.2022 10:15 | Dragofer | Status | new => closed |
24.12.2022 10:15 | Dragofer | Resolution | open => no change required |
24.12.2022 10:15 | Dragofer | Note Added: 0015633 |