View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005094 | DarkRadiant | Renderer | public | 01.01.2020 05:06 | 08.11.2020 18:36 |
| Reporter | greebo | Assigned To | greebo | ||
| Priority | normal | Severity | normal | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.7.0 | ||||
| Target Version | 2.7.0 | Fixed in Version | 2.7.0 | ||
| Summary | 0005094: Choose Skin dialog will crash in 2.7.0pre2 | ||||
| Description | It appears there is a GL context problem in the DR 2.7.0 pre-release versions, causing the choose skin preview widget to fail in debug builds. | ||||
| Steps To Reproduce | Use the map below and open it in DR. Select one bed and select the skin spawnarg in the Entity Inspector Hit "Choose Skin" which will crash due to the glGenLists() call failing to create a display list Version 2 // entity 0 { "classname" "func_static" "name" "func_static_1" "origin" "61 34 41" "rotation" "1 0 0 0 1 0 0 0 1" "model" "models/darkmod/furniture/beds/builder_bed01.lwo" "skin" "beds/builder_coarse" } // entity 1 { "classname" "func_static" "name" "func_static_2" "origin" "220 29 41" "rotation" "1 0 0 0 1 0 0 0 1" "model" "models/darkmod/furniture/beds/builder_bed01.lwo" "skin" "beds/builder_coarse" } | ||||
| Tags | No tags attached. | ||||
|
DarkRadiant: master 09a069d2 02.01.2020 18:10 Details Diff |
Fix 0005094 by preventing the ModelPreview::setModel/setSkin methods immediately propagating the setting to the scene, triggering GL calls in the background when potentially no GL context is present yet. With this change the model/skin changes are applied in the onPreRender() method which is always invoked with a current context. |
Affected Issues 0005094 |
|
| mod - libs/wxutil/preview/ModelPreview.cpp | Diff File | ||
| mod - libs/wxutil/preview/ModelPreview.h | Diff File | ||
| mod - libs/wxutil/preview/RenderPreview.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 01.01.2020 05:06 | greebo | New Issue | |
| 01.01.2020 05:07 | greebo | Status | new => confirmed |
| 02.01.2020 17:10 | greebo | Assigned To | => greebo |
| 02.01.2020 17:10 | greebo | Status | confirmed => assigned |
| 02.01.2020 17:10 | greebo | Target Version | => 2.7.0 |
| 02.01.2020 18:01 | greebo | Status | assigned => resolved |
| 02.01.2020 18:01 | greebo | Resolution | open => fixed |
| 02.01.2020 18:01 | greebo | Fixed in Version | => 2.7.0 |
| 07.01.2020 18:56 | greebo | Relationship added | related to 0005114 |
| 09.01.2020 19:25 | greebo | Changeset attached | => DarkRadiant master 09a069d2 |
| 08.11.2020 18:36 | greebo | Status | resolved => closed |
