View Issue Details

IDProjectCategoryView StatusLast Update
0005097DarkRadiantGUIpublic26.11.2020 15:11
ReporterBikerdude Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
PlatformPCOSWindowsOS Version8.1
Product Version2.8.0 
Target Version2.9.2Fixed in Version2.9.2 
Summary0005097: Layer toggle controls can get out of sync (showing wrong icons)
DescriptionWhere the button after being clicked on will remove the tick mark, but will show blue on the button.
Steps To ReproduceOpen DR -

- Use DR normally for while (so far longer than 2 hrs)
- Open the layers window,
- click on any of the layers buttons to hide or show a layer,
- the layer will hide and show as normal -

The issue -

- the color of the button WILL toggle off/on (so the layer is being hidden/revealed etc)
- but the tick will continue to be shown.
Additional Information- only work around is to close and re-open layers window.
Tagslayers window

Relationships

related to 0005391 resolvedgreebo On/off Selection issue with layers window 

Activities

Bikerdude

Bikerdude

02.01.2020 15:13

reporter  

layers child window.JPG (221,151 bytes)   
layers child window.JPG (221,151 bytes)   
Bikerdude

Bikerdude

05.05.2020 15:42

reporter   ~0012468

The only work around is to close and reopen the layers window.
Bikerdude

Bikerdude

09.10.2020 21:11

reporter   ~0012804

Dont know if this is fixable, but this is still happening.
Bikerdude

Bikerdude

03.11.2020 12:31

reporter   ~0012857

The work around is to close and re-open the effect window.
Bikerdude

Bikerdude

08.11.2020 20:03

reporter   ~0012874

Still happening, regular as clockwork in 2.8
Bikerdude

Bikerdude

10.11.2020 09:39

reporter   ~0012885

Is related to 005391
Bikerdude

Bikerdude

13.11.2020 16:52

reporter   ~0012907

@Greebo, do you think this is also linked or related to the 'wxToggleButton' function somehow..?
Bikerdude

Bikerdude

17.11.2020 15:39

reporter   ~0012967

Will test and see if this issue got resolved in 2.9pre3 as a result of the fix implemented in 0005391
Bikerdude

Bikerdude

18.11.2020 12:00

reporter   ~0012984

Still preset in 2.9pre3.
greebo

greebo

19.11.2020 03:38

administrator   ~0012987

To clarify, the behaviour is that the layer is hidden but the tick mark is drawn on the corresponding toggle button as if it were visible?
Bikerdude

Bikerdude

19.11.2020 10:36

reporter   ~0012991

Last edited: 19.11.2020 13:50

View 2 revisions

Hold fire for now, as I think the other layers window fix you have done for pre3 may have fixed it. I have had DR open for 2hours and so far the issue hasen't appeared.
Bikerdude

Bikerdude

19.11.2020 15:33

reporter   ~0012995

Ok, so it turned out I just needed DR open for longer than 2hrs for the issue to happen again.

So in answer for your question, yes the behavior is that the layer is hidden but the tick mark is drawn on the corresponding toggle button as if it were visible. See attached, the only visible layers are default and manor_gnd.
Capture.JPG (71,387 bytes)   
Capture.JPG (71,387 bytes)   
Bikerdude

Bikerdude

19.11.2020 15:37

reporter   ~0012996

I just spotted another issue related to this bug, when the above issue is happening the 'Show all' becomes un-togglable and stays grayed-out.
greebo

greebo

19.11.2020 18:08

administrator   ~0012998

Ok, so it seems that it's possible for the layers window to get its visual state out of sync with the state of the LayerSystem in the backend. Especially if opening and closing the dialog will fix it, because that's when the dialog will reload all its controls and sync the state with the LayerSystem.

There must be some steps leading up to that issue, do you remember doing anything special before that? Are you just clicking the toggles, or is this happening without any interaction?
Not sure if the run time plays any role, except for making the steps more likely to happen.
greebo

greebo

19.11.2020 18:32

administrator   ~0012999

I'll check in a change that might have an effect on this issue - maybe you can have a look at it in the next pre-release build.
Bikerdude

Bikerdude

19.11.2020 20:26

reporter   ~0013000

Hi Greebo

Regarding states/steps, I am fairly sure I can just leave DR along without touching it and it will exibit the same issue. So tonight before going to bed I will load DR with a map loaded (bhm) and see whats its state is like in the morning.

And yes am more than happy to test the change with the next build.
Bikerdude

Bikerdude

20.11.2020 08:36

reporter   ~0013003

Morning

So leaving DR running for 8hrs with no input didn't reproduce the issue.
greebo

greebo

24.11.2020 16:45

administrator   ~0013014

There's a new pre-release version (2.9.2pre2) available here, maybe you can check out if the behaviour is improved now.
https://drive.google.com/file/d/1xSFPORJp7XD_brI2B55fl-0EFXRYqAQt/view?usp=sharing
Bikerdude

Bikerdude

24.11.2020 17:01

reporter   ~0013015

Downloading and will test first thing in the morning.
Bikerdude

Bikerdude

26.11.2020 10:08

reporter   ~0013023

Am currently testing.
Bikerdude

Bikerdude

26.11.2020 13:40

reporter   ~0013024

tested (2.9.2pre2) for a few hours this morning, and the issue hasn't recurred. So this tracker can be closed.

thanks for fixing this :-)
greebo

greebo

26.11.2020 15:10

administrator   ~0013025

Nice, thanks for testing

Related Changesets

DarkRadiant: master 41d4a84b

2020-11-19 18:04:00

greebo

Details Diff
0005097: Maybe not directly related to the described issue, but the lock should have a name to prevent it from being destructed immediately after construction. Affected Issues
0005097
mod - radiant/ui/layers/LayerControl.cpp Diff File

DarkRadiant: master de1bffd9

2020-11-19 18:31:51

greebo

Details Diff
0005097: Instead of setting the icons ourselves, tell wxWidgets about the images it needs to render when the toggle is active/inactive Affected Issues
0005097
mod - radiant/ui/layers/LayerControl.cpp Diff File

Issue History

Date Modified Username Field Change
02.01.2020 15:13 Bikerdude New Issue
02.01.2020 15:13 Bikerdude Tag Attached: layers window
02.01.2020 15:13 Bikerdude File Added: layers child window.JPG
06.01.2020 19:39 Bikerdude Summary Layers child window showing weird selection behavour. => Layers child window exibiting weird selection behavour.
06.01.2020 19:39 Bikerdude Steps to Reproduce Updated View Revisions
06.01.2020 21:53 Bikerdude Steps to Reproduce Updated View Revisions
05.05.2020 15:42 Bikerdude Note Added: 0012468
09.10.2020 21:11 Bikerdude Note Added: 0012804
03.11.2020 12:31 Bikerdude Note Added: 0012857
08.11.2020 20:03 Bikerdude Note Added: 0012874
09.11.2020 11:21 Bikerdude Product Version 2.6.0 => 2.8.0
09.11.2020 14:22 Dragofer Relationship added related to 0005391
10.11.2020 09:39 Bikerdude Summary Layers child window exibiting weird selection behavour. => Layers child window exhibiting weird selection behavour.
10.11.2020 09:39 Bikerdude Note Added: 0012885
13.11.2020 16:52 Bikerdude Note Added: 0012907
17.11.2020 15:39 Bikerdude Note Added: 0012967
18.11.2020 12:00 Bikerdude Note Added: 0012984
19.11.2020 03:38 greebo Note Added: 0012987
19.11.2020 10:36 Bikerdude Steps to Reproduce Updated View Revisions
19.11.2020 10:36 Bikerdude Note Added: 0012991
19.11.2020 13:50 Bikerdude Note Edited: 0012991 View Revisions
19.11.2020 15:33 Bikerdude Note Added: 0012995
19.11.2020 15:33 Bikerdude File Added: Capture.JPG
19.11.2020 15:35 Bikerdude Steps to Reproduce Updated View Revisions
19.11.2020 15:37 Bikerdude Note Added: 0012996
19.11.2020 18:08 greebo Note Added: 0012998
19.11.2020 18:29 greebo Summary Layers child window exhibiting weird selection behavour. => Layer toggle controls can get out of sync (showing wrong icons)
19.11.2020 18:32 greebo Note Added: 0012999
19.11.2020 18:32 greebo Assigned To => greebo
19.11.2020 18:32 greebo Status new => assigned
19.11.2020 18:32 greebo Changeset attached => DarkRadiant master 41d4a84b
19.11.2020 18:32 greebo Changeset attached => DarkRadiant master de1bffd9
19.11.2020 20:26 Bikerdude Note Added: 0013000
20.11.2020 08:36 Bikerdude Note Added: 0013003
24.11.2020 16:45 greebo Note Added: 0013014
24.11.2020 17:01 Bikerdude Note Added: 0013015
26.11.2020 10:08 Bikerdude Note Added: 0013023
26.11.2020 13:40 Bikerdude Note Added: 0013024
26.11.2020 15:10 greebo Status assigned => resolved
26.11.2020 15:10 greebo Resolution open => fixed
26.11.2020 15:10 greebo Fixed in Version => 2.9.2
26.11.2020 15:10 greebo Note Added: 0013025
26.11.2020 15:11 greebo Target Version => 2.9.2