View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0005365||The Dark Mod||Graphics||public||23.10.2020 17:24||07.11.2020 17:28|
|Status||closed||Resolution||no change required|
|Product Version||TDM 2.08|
|Target Version||TDM 2.09||Fixed in Version||TDM 2.08|
|Summary||0005365: Portal Sky has been partially broken since 2.05|
Issue is that unless a brush touches another brush or is part of a brush touching the void, portal_sky renders nothing.
In 2.08 and SVN: https://forums.thedarkmod.com/uploads/monthly_2020_10/darkmod_2020-10-23_09_24_47.jpg.dd97cfb0afdea42f326b6cc00e61ee78.jpg
In 2.04: https://forums.thedarkmod.com/uploads/monthly_2020_10/darkmod_2020-10-23_13_15_09.jpg.12e27f3e6a41cc4c922b03c2e24114ad.jpg
Test Map below.
There were some changes for 2.05 that dealt directly with skyboxes: "duzenko Optimize Skybox rendering by changing it's render order (takes better advantage of hierarchical-z)"
|Steps To Reproduce||I've attached a small test map.|
|Tags||No tags attached.|
Uploaded better example map
skytest.zip (47,193 bytes)
Works with g_enablePortalSky 1
darkmod_2020-10-23_15.58.04.jpg (557,760 bytes)
The idea behind the sky optimization is, there's nothing behind it
The sky in your test map actually renders, but at infinity and get overdrawn by the room floor afterwards
Use r_subviewOnly 1 to check
Do you want something like Prey 2005 portals? https://youtu.be/x8R1XCojhdI?t=4486
In my map I have a hole in the cave ceiling that moonlight streams in from.
In the attached picture you can see it circled in red.
This worked just fine up until 2.05, don't know why I didn't notice it not working before this though.
EDIT: Also yes, it would be something I was going to use in this map also for a portal effect.
holeincave.jpg (586,783 bytes)
I think as long as nothing overlaps the sky from behind you should be good
If you do have something at the back then we can discuss this as a new feature but it's not a skybox by definition
In the picture I posted, you can see circled in red, that the skybox I made is floating in the map, it's not touching an outside wall.
I recorded a quick video in game: https://www.youtube.com/watch?v=_Blr2LBcvC8
|To make a proper skybox, you realign the borders of that big room so the other cube with skyportal material has its walls next to the void, with nothing else between.|
|@Judith that's how it works now, but up until v2.05 it didn't work that way, you could have a skyportal on any face anywhere in your map and get the desired effect.|
Then it was like some other sort of a camera, I guess. Current skybox implementation is "by-the-book", and in line with how it works in other engines with subtractive geometry, where skybox was basically rendered instead of the void, and the skyportal was mostly just an invisible material that let you show it.
IMO the feature you want should be made separate as another camera entity type.
To reiterate, I think what you want should be filed under feature request rather than bugs
But then again, if you just need a sky, it will be easier for everyone if you just slam it against the void
|Okay, I'll do my best to modify the map to accommodate the optimizations|
|Closing bug report as it is working as intended.|
|23.10.2020 17:24||AluminumHaste||New Issue|
|23.10.2020 17:24||AluminumHaste||File Added: skytest.zip|
|23.10.2020 18:18||AluminumHaste||Assigned To||=> duzenko|
|23.10.2020 18:18||AluminumHaste||Status||new => assigned|
|23.10.2020 19:34||AluminumHaste||File Deleted: skytest.zip|
|23.10.2020 19:35||AluminumHaste||Note Added: 0012821|
|23.10.2020 19:35||AluminumHaste||File Added: skytest.zip|
|23.10.2020 20:02||AluminumHaste||Note Added: 0012822|
|23.10.2020 20:02||AluminumHaste||File Added: darkmod_2020-10-23_15.58.04.jpg|
|24.10.2020 03:27||nbohr1more||Relationship added||child of 0004414|
|24.10.2020 07:16||duzenko||Note Added: 0012823|
|24.10.2020 07:18||duzenko||Note Edited: 0012823||View Revisions|
|24.10.2020 12:12||AluminumHaste||Note Added: 0012824|
|24.10.2020 12:12||AluminumHaste||File Added: holeincave.jpg|
|24.10.2020 12:13||AluminumHaste||Note Edited: 0012824||View Revisions|
|24.10.2020 18:31||duzenko||Note Added: 0012825|
|25.10.2020 13:10||AluminumHaste||Note Added: 0012826|
|25.10.2020 17:32||Judith||Note Added: 0012829|
|25.10.2020 18:13||AluminumHaste||Note Added: 0012830|
|25.10.2020 18:25||Judith||Note Added: 0012831|
|26.10.2020 15:07||duzenko||Note Added: 0012833|
|27.10.2020 12:51||AluminumHaste||Note Added: 0012845|
|27.10.2020 12:57||AluminumHaste||Status||assigned => closed|
|27.10.2020 12:57||AluminumHaste||Resolution||open => no change required|
|27.10.2020 12:57||AluminumHaste||Fixed in Version||=> TDM 2.08|
|27.10.2020 12:57||AluminumHaste||Note Added: 0012846|
|07.11.2020 17:28||VanishedOne||Relationship added||related to 0004635|