View Issue Details

IDProjectCategoryView StatusLast Update
0005713DarkRadiantSaving and loadingpublic22.08.2021 15:57
Reporterillwieckz Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.13.0 
Target Version2.14.0Fixed in Version2.14.0 
Summary0005713: PatchDefExporter: do not write trailing white space after shader name
DescriptionThis is the sidecar ticket to go with this Pull Request: https://github.com/codereader/DarkRadiant/pull/18

Quote:

Do not write trailing white space after shader name when writing Q3 PatchDef format.

Otherwise it writes something like this (white space “ ” replaced by “⎵” character to make it obvious):

```
patchDef2
{
shared_vega/panel07⎵
( 3 3 0 0 0 )
(

```

Instead of:

```
patchDef2
{
shared_vega/panel07
( 3 3 0 0 0 )
(

```

This would also add a lot of diff noise when one contributor uses DarkRadiant and another contributor uses another Radiant, those lines would be entirely rewritten on saving to add or remove the trailing white space given one editor or another is used.
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

DarkRadiant: master f92ad92b

2021-08-22 15:49:04

greebo


Committer: GitHub Details Diff
0005713: Merge pull request 0000018 from illwieckz/patchdef

PatchDefExporter: do not write trailing white space after shader name
Affected Issues
0000018, 0005713
mod - radiantcore/map/format/primitivewriters/PatchDefExporter.h Diff File

Issue History

Date Modified Username Field Change
13.08.2021 18:21 illwieckz New Issue
13.08.2021 19:00 greebo Status new => confirmed
22.08.2021 15:49 greebo Changeset attached => DarkRadiant master f92ad92b
22.08.2021 15:57 greebo Target Version => 2.14.0
22.08.2021 15:57 greebo Assigned To => greebo
22.08.2021 15:57 greebo Status confirmed => resolved
22.08.2021 15:57 greebo Resolution open => fixed
22.08.2021 15:57 greebo Fixed in Version => 2.14.0