View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005834 | The Dark Mod | Coding | public | 08.12.2021 04:53 | 22.08.2022 17:16 |
Reporter | stgatilov | Assigned To | stgatilov | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | duplicate | ||
Product Version | TDM 2.10 | ||||
Target Version | TDM 2.11 | ||||
Summary | 0005834: Refactor: merge interaction and ambient shaders | ||||
Description | We have too much code duplication. Ambient and normal lights are very similar in general, except for: 1) different diffuse and specular term 2) ambient occlusion instead of shadows There is no need to have separate shaders. | ||||
Additional Information | See also: https://forums.thedarkmod.com/index.php?/topic/21138-projected-lights-falloff/&do=findComment&comment=466904 | ||||
Tags | No tags attached. | ||||
OMG... I created so many tickets about this shaders cleaning, which are mostly duplicates of each other =) Due to 0005828, now interaction and ambient lighting model are in two pure functions which one can include and use anywhere. I don't think putting this stuff into single shader will help much, because set of differences are rather big: 1) ambient uses terms which depend on world normal, while interaction uses normal in tangent space 2) shadows vs SSAO as mentioned 3) ambient shader has ambient color tweaks (r_ambientMinLevel and r_ambientGamma) 4) interaction shader has some rim/fresnel math, which I don't like... but it works as specular amplifier and won't fit in ambient. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
08.12.2021 04:53 | stgatilov | New Issue | |
08.12.2021 04:53 | stgatilov | Status | new => assigned |
08.12.2021 04:53 | stgatilov | Assigned To | => stgatilov |
08.12.2021 04:59 | stgatilov | Relationship added | related to 0005835 |
27.12.2021 03:49 | stgatilov | Relationship added | related to 0005285 |
22.08.2022 17:16 | stgatilov | Note Added: 0015204 | |
22.08.2022 17:16 | stgatilov | Relationship added | related to 0005828 |
22.08.2022 17:16 | stgatilov | Relationship deleted | related to 0005828 |
22.08.2022 17:16 | stgatilov | Relationship added | duplicate of 0005828 |
22.08.2022 17:16 | stgatilov | Status | assigned => closed |
22.08.2022 17:16 | stgatilov | Resolution | open => duplicate |