View Issue Details

IDProjectCategoryView StatusLast Update
0006274DarkRadiantMap Editingpublic20.03.2023 10:39
Reportergreebo Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version3.8.0 
Target Version3.9.0Fixed in Version3.9.0 
Summary0006274: Empty rotation when cloning an entity using editor_rotatable and an angle key
DescriptionIf you have an "editor_rotatable" entity but are using the "angle" key and not the "rotation" key, there is a bug when cloning an entity where the cloned entity has a identity rotation matrix (and thus, it's arrow is wrong).

See PR https://github.com/codereader/DarkRadiant/pull/36

The fix is in place, it just needs a complementary unit test.
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

DarkRadiant: master 77ed22df

20.03.2023 08:47

chalonverse


Details Diff
Add unit tests for 0006274

(cherry picked from commit fa18e656e78edfc0cd15bae7fc84efdaea51abfe)
Affected Issues
0006274
mod - test/Entity.cpp Diff File
add - test/resources/tdm/def/gameplay.def Diff File

DarkRadiant: master 5d4eecf9

20.03.2023 10:38

greebo

Committer: GitHub


Details Diff
0006274: Merge pull request 0000036 from chalonverse/rot-dupe-fix

Fix bug where cloning an entity using editor_rotatable and an angle key would cause the rotation matrix to be reset by an empty rotation key
Affected Issues
0000036, 0006274
mod - radiantcore/entity/generic/GenericEntityNode.cpp Diff File
mod - test/Entity.cpp Diff File
add - test/resources/tdm/def/gameplay.def Diff File

Issue History

Date Modified Username Field Change
20.03.2023 04:09 greebo New Issue
20.03.2023 10:38 chalonverse Changeset attached => DarkRadiant master 77ed22df
20.03.2023 10:38 greebo Changeset attached => DarkRadiant master 5d4eecf9
20.03.2023 10:39 greebo Assigned To => greebo
20.03.2023 10:39 greebo Status new => resolved
20.03.2023 10:39 greebo Resolution open => fixed
20.03.2023 10:39 greebo Fixed in Version => 3.9.0
20.03.2023 10:39 greebo Target Version => 3.9.0