View Issue Details

IDProjectCategoryView StatusLast Update
0003122The Dark ModCodingpublic19.12.2020 20:52
Reportertels Assigned Tonbohr1more  
PrioritylowSeverityfeatureReproducibilityN/A
Status closedResolutionwon't fix 
Product VersionTDM 1.07 
Summary0003122: Add ambient and frobhighlight macros to the material parser
DescriptionThese two are in almost every material, are quite long, and thus error prone and hard to change afterwards.
Additional Informationhttp://forums.thedarkmod.com/topic/13796-extending-the-material-parser/page__view__findpost__p__286986
TagsNo tags attached.

Relationships

related to 0003121 resolvedtels Add particle macro 
related to 0004799 closednbohr1more ship_hull_dark doesn't contain an ambient method for when global5 == 2 
related to 0005427 assignedcabalistic Move Frob-Highlight to GLSL 
related to 0005449 resolvedstgatilov Remove obsolete "Ambient Method" stages form materials 

Activities

tels

tels

11.05.2012 13:36

reporter   ~0004568

We can then also remove game/MaterialConverter.cpp and game/MaterialConverter.h

user81

28.03.2018 10:31

  ~0010234

@nbohr1more, didnt this get fixed ages ago..?
nbohr1more

nbohr1more

28.03.2018 18:49

developer   ~0010321

We don't have macros for these yet.
We no longer need the Enhanced Ambient macro.

I can look at that for 2.07 but there is a plan to replace the simple ambient too so the only thing we'd look at is a frob macro (maybe).

user81

28.03.2018 18:55

  ~0010323

grand.
nbohr1more

nbohr1more

27.05.2018 15:31

developer   ~0010474

As a sub-task, we should remove all the enhanced ambient stages from the material defs.
nbohr1more

nbohr1more

28.06.2018 16:16

developer   ~0010605

This is suspended.

The better approach is to create an branch in the ambient shader that does a simple additive blend and ignore the conditional material stages.
nbohr1more

nbohr1more

09.12.2020 00:35

developer   ~0013114

Closing.

Advanced ambient settings were removed from the GUI in 2.08

Frob highlight will eventually be moved to GLSL
nbohr1more

nbohr1more

19.12.2020 20:52

developer   ~0013168

Ambient stages removed in 0005449

Issue History

Date Modified Username Field Change
09.05.2012 06:34 tels New Issue
09.05.2012 06:40 tels Product Version => TDM 1.07
11.05.2012 08:40 tels Relationship added related to 0003121
11.05.2012 13:36 tels Note Added: 0004568
28.03.2018 10:31 user81 Note Added: 0010234
28.03.2018 18:49 nbohr1more Note Added: 0010321
28.03.2018 18:50 nbohr1more Assigned To => nbohr1more
28.03.2018 18:50 nbohr1more Status new => assigned
28.03.2018 18:50 nbohr1more Target Version => TDM 2.07
28.03.2018 18:55 user81 Note Added: 0010323
27.05.2018 15:29 nbohr1more Relationship added related to 0004799
27.05.2018 15:31 nbohr1more Note Added: 0010474
28.06.2018 16:15 nbohr1more Status assigned => suspended
28.06.2018 16:15 nbohr1more Target Version TDM 2.07 =>
28.06.2018 16:16 nbohr1more Note Added: 0010605
07.12.2020 20:47 nbohr1more Relationship added related to 0005427
09.12.2020 00:35 nbohr1more Note Added: 0013114
09.12.2020 00:36 nbohr1more Status suspended => closed
09.12.2020 00:36 nbohr1more Resolution open => won't fix
19.12.2020 20:51 nbohr1more Relationship added related to 0005449
19.12.2020 20:52 nbohr1more Note Added: 0013168