View Issue Details

IDProjectCategoryView StatusLast Update
0006337The Dark ModGUIpublic06.01.2024 23:15
ReporterDragofer Assigned Tostgatilov  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
Product VersionTDM 2.11 
Target VersionTDM 2.12Fixed in VersionTDM 2.12 
Summary0006337: Misalignment in mission lists
DescriptionSince TDM 2.11-beta05 all mission lists in TDM's menus i.e. in the mission downloader show a slight misalignment of entries compared to the background table. The top rows still look fine, but it gets more pronounced towards the bottom rows (see also attached .jpg). This appears to be independent of resolution as far as I've tested, and 3 out of 3 other people are seeing the same thing.

Bisecting showed that beta04-16714-10226 was still fine while beta05-16727-10239 first starts showing the issue. The most suspicious changes imo are revs 16721 to 16723 and rev 10232-10233.
Tagsgui
Attached Files
misalignment.jpg (562,441 bytes)

Relationships

related to 0005914 resolvedDragofer Add subtitles to New Job 
related to 0005249 resolvednbohr1more Some mission names are not displayed well in the Start mission screen 
related to 0006339 new Polishing menus: mission downloader 

Activities

stgatilov

stgatilov

06.01.2024 19:28

administrator   ~0016327

It was svn rev 10233.

Specifically, I removed rounding of text height from here:
    float idDeviceContext::MaxCharHeight(float scale) {
    SetFontByScale(scale);
    float useScale = scale * useFont->glyphScale;
    return idMath::FtoiTrunc( activeFont->maxHeight * useScale ); // this Ftoi is deleted
    }

In my opinion it is wrong to round anything to integers.
If you decide to scale text +25%, then it should be +25% larger regardless of what its size was.
Moreover, as far as I remember, this rounding happens in GUI coordinates, i.e. in 640 x 480 pixels.

So my opinion is: better fix text scaling coefficient.
stgatilov

stgatilov

06.01.2024 19:36

administrator   ~0016328

Fixed in svn rev 16892.
nbohr1more

nbohr1more

06.01.2024 22:11

developer   ~0016333

This has broken the fix for 0005249
nbohr1more

nbohr1more

06.01.2024 23:14

developer   ~0016334

Nevermind, the side-pane detail view is sufficient to expose the full title and it is rendered properly there.

Issue History

Date Modified Username Field Change
12.11.2023 19:39 Dragofer New Issue
12.11.2023 19:39 Dragofer File Added: misalignment.jpg
12.11.2023 19:39 Dragofer Description Updated
12.11.2023 21:00 Dragofer Relationship added related to 0006339
29.12.2023 15:10 Fiver Tag Attached: gui
06.01.2024 19:26 stgatilov Relationship added related to 0005914
06.01.2024 19:28 stgatilov Note Added: 0016327
06.01.2024 19:36 stgatilov Note Added: 0016328
06.01.2024 19:36 stgatilov Assigned To => stgatilov
06.01.2024 19:36 stgatilov Status new => resolved
06.01.2024 19:36 stgatilov Resolution open => fixed
06.01.2024 19:36 stgatilov Fixed in Version => TDM 2.12
06.01.2024 22:11 nbohr1more Status resolved => feedback
06.01.2024 22:11 nbohr1more Resolution fixed => reopened
06.01.2024 22:11 nbohr1more Note Added: 0016333
06.01.2024 22:11 nbohr1more Relationship added related to 0005249
06.01.2024 23:14 nbohr1more Note Added: 0016334
06.01.2024 23:15 nbohr1more Status feedback => resolved
06.01.2024 23:15 nbohr1more Resolution reopened => fixed